Skip to content

Fix tests if not TZ change allowed#893

Merged
pganssle merged 2 commits into
dateutil:masterfrom
shadchin:fix_tests
Nov 2, 2019
Merged

Fix tests if not TZ change allowed#893
pganssle merged 2 commits into
dateutil:masterfrom
shadchin:fix_tests

Conversation

@shadchin

@shadchin shadchin commented Feb 27, 2019

Copy link
Copy Markdown
Contributor

Summary of changes

Pull Request Checklist

  • Changes have tests
  • Authors have been added to AUTHORS.md
  • News fragment added in changelog.d. See CONTRIBUTING.md for details

@pganssle pganssle changed the title TST: Fix tests if not TZ change allowed Fix tests if not TZ change allowed Feb 27, 2019
@pganssle

pganssle commented Feb 27, 2019

Copy link
Copy Markdown
Member

Hm... This seems OK, but maybe we can just call pytest.skip in the TzContext object instead?

@shadchin

Copy link
Copy Markdown
Contributor Author

Done

@shadchin

Copy link
Copy Markdown
Contributor Author

Hi, this PR ok or need fix something?

@pganssle

Copy link
Copy Markdown
Member

@shadchin Nope, I have it on my to-do list to do a few nitpicky clean up things and then merge this, sorry for the delay in merging.

@pganssle pganssle added this to the 2.8.1 milestone Nov 2, 2019
At the moment these tests are skipped ad-hoc in the test suite, but we
can use `pytest.skip` in the context manager itself to skip them
automatically and make things easier on ourselves.
@pganssle
pganssle merged commit e31bd87 into dateutil:master Nov 2, 2019
@pganssle pganssle mentioned this pull request Nov 3, 2019
@shadchin
shadchin deleted the fix_tests branch November 6, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants