REF: collect parser methods by function#882
Merged
Merged
Conversation
Contributor
Author
|
failed build is pypy, looks unrelated |
pganssle
approved these changes
Feb 26, 2019
pganssle
left a comment
pganssle
left a comment
Member
There was a problem hiding this comment.
Yeah I think this is a nicer arrangement for the code.
Can you add a misc item to the changelog?
Contributor
Author
Done. Is there a better word than "Fixed" in this context? |
Member
|
@jbrockmendel I often go with "Patch by ..." when contributing to CPython, but no need to worry. For the moment, these MISC things don't actually generate entries directly in the changelog (though I'm thinking maybe that should change). |
This is a minor refactoring to improve the code organization.
This is merged in the branch for PR dateutil#882 because PR dateutil#735 was accidentally merged without a changelog.
pganssle
force-pushed
the
send_upstream
branch
from
February 26, 2019 20:05
17d81a5 to
86ad6b0
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods within
parserare a bit of a jumble. This separates out two sections for methods that a) act on individual tokens and b) are for creating the datetime output after the string is fully parsed.No hurry on this if it would cause rebasing conflicts elsewhere.
Methods are unchanged, with the exception of a long line in a comment in to_decimal that is wrapped.