Catch non-ValueError exceptions in decimal#636
Merged
Conversation
pganssle
force-pushed
the
decimal_conversion
branch
from
March 12, 2018 17:19
b3410e1 to
5f2052f
Compare
Member
Author
|
@amureki Looks good? |
amureki
approved these changes
Mar 13, 2018
amureki
left a comment
amureki
left a comment
There was a problem hiding this comment.
I tried it on our system, worked fine in previously broken cases. So it looks good to me! ✨
P.S. Small comment regarding TODO, but it is completely up to you.
| # HH:MM[:SS[.ss]] | ||
| res.hour = int(value) | ||
| value = Decimal(tokens[idx + 2]) # TODO: try/except for this? | ||
| value = self._to_decimal(tokens[idx + 2]) # TODO: try/except for this? |
There was a problem hiding this comment.
Shall we remove TODO comment from here? Since we are covering this in _to_decimal.
Member
Author
There was a problem hiding this comment.
Well, _to_decimal can still raise a ValueError, and that TODO predates the switch to Decimal:
3b43612#diff-4b65e7edb2b73639d2d3360fa8d05343L935
That said, I don't really know what it refers to. I'll leave it in for now.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #632.
This adds both function call overhead and exception catching overhead to the function. Based on running
%timeiton a few strings, the cost is on the order of a few microseconds out of 60-100 microseconds. If we can come up with a version that doesn't have to re-raise, that might be preferable.Also, we could theoretically add whatever errors
Decimalis raising into the huge try-except loop and handle it that way, but the documentation doesn't seem to clearly enumerate an exception hierarchy fordecimal.Decimal, so I'm not confident that we could catch the "root" exception easily.