[WIP] Add new build options for setup.py#613
Open
pganssle wants to merge 2 commits into
Open
Conversation
pganssle
force-pushed
the
zoneinfo_build_options
branch
from
January 18, 2018 21:00
4d574e9 to
4988a1b
Compare
Merged
pganssle
force-pushed
the
zoneinfo_build_options
branch
from
January 18, 2018 21:48
4988a1b to
e1f6ea1
Compare
ghost
suggested changes
Jan 19, 2018
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Please add an entry to the NEWS file about this new possibility for packagers (so they notice it without digging in the code).
Member
Author
|
@wagner-certat The current release procedure doesn't generate the NEWS file until the release is prepared, though I would like to change that with #592. That said, "add documentation" is one of the bullet points. |
pganssle
force-pushed
the
zoneinfo_build_options
branch
from
April 11, 2018 21:23
e1f6ea1 to
5b306a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #597.
This will add the
--no-zoneinfo,--tzfilesand--tzpathcommand line arguments so that downstream distributors can easily build versions of this where they are better able to manage howzoneinfofiles are distributed.To do:
zoneinfotarball is not distributed.sdist?pipCC: @wagner-certat @agx @ericvw @jelly @hguemar
Thoughts from downstream distributors about how much this would help? Would something else be preferable?
The whole thing is a bit of a monstrous hack, unfortunately, but I think it's slightly preferable to everyone patching themselves.