Add resolve_imaginary#607
Merged
Merged
Conversation
This was referenced Jan 3, 2018
Contributor
|
Yes it was a nightmare as I worked on the master branch. Thanks for tidy it up eventually and I hope my work helps (not causing too much trouble). Definitely started a new fork when you have taken over and after make sure that deleting my fork will not delete the edit done. |
pganssle
force-pushed
the
resolve_imaginary
branch
from
January 4, 2018 18:53
5918f4c to
2d7a7b5
Compare
pganssle
force-pushed
the
resolve_imaginary
branch
from
January 4, 2018 19:15
2d7a7b5 to
3db34ec
Compare
Member
Author
|
Only problem is a dead link, merging. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #339 in favor of #565 and #593.
@Cheukting I had to make a new branch to clean up your git history, which wouldn't have merged cleanly into the master branch as it was. If you make further PRs, it would probably be advisable to delete your fork and make a new one, because I think the master branch is out of sync with the master branch here.