Deprecate tz format#606
Merged
Merged
Conversation
Contributor
|
I will take a look today at this when I get home. |
pganssle
force-pushed
the
deprecate_tz_format
branch
from
January 3, 2018 18:59
9c5f40e to
3b7b558
Compare
pganssle
commented
Jan 3, 2018
| >>> datetime(2003, 10, 26, 0, 59, tzinfo=tz).tzname() | ||
| 'EDT' | ||
| >>> datetime(2003, 10, 26, 1, 00, tzinfo=tz).tzname() | ||
| >>> datetime(2003, 10, 26, 2, 00, tzinfo=tz).tzname() |
Member
Author
There was a problem hiding this comment.
I think this indicates we're not testing the doctests. Probably we should figure out how to mock out now in doctests so that we can actually get passing doctests.
pablogsal
approved these changes
Jan 3, 2018
pablogsal
left a comment
pablogsal
left a comment
Contributor
There was a problem hiding this comment.
Apart from the suggestion, LGTM
| 'is now deprecated; support for parsing this format ' + | ||
| 'will be removed in future versions. It is recommended ' + | ||
| 'that you switch to a standard format like the GNU ' + | ||
| 'TZ variable format.', tz.DeprecatedTzFormatWarning) |
Contributor
There was a problem hiding this comment.
Suggestion: Include link to the GNU TZ variable format either withing dateutil documentation or to the format specification.
Member
Author
There was a problem hiding this comment.
That's a good idea, and one I considered. I think it is in the tzstr documentation. I'm a bit hesitant to add it here, since I'm afraid of it going out of date. I'll merge this for now, we can tweak the message later.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #595.
This is a release blocker, so we should get this out ASAP.
CC: @pablogsal