Skip to content

Adds python_require#552

Merged
pganssle merged 1 commit into
dateutil:masterfrom
jakec-github:master
Dec 6, 2017
Merged

Adds python_require#552
pganssle merged 1 commit into
dateutil:masterfrom
jakec-github:master

Conversation

@jakec-github

Copy link
Copy Markdown
Contributor

This closes #537

Adds python_require to setup() in setup.py. Only works for users installing with pip 9 or above. Will warn if setuptools version is <=24.3.

Also help from Stefan Bonchev

@pganssle

pganssle commented Dec 6, 2017

Copy link
Copy Markdown
Member

The setuptools.__version__ check should use distutils.version.LooseVersion (or StrictVersion):

Here's a link to explain how it works: https://stackoverflow.com/questions/11887762/compare-version-strings-in-python

@jakec-github

Copy link
Copy Markdown
Contributor Author

I used LooseVersion to compare setuptools versions since it should work a little more reliably

@pganssle
pganssle merged commit 40581bb into dateutil:master Dec 6, 2017
@pganssle pganssle added this to the 2.7.0 milestone Dec 7, 2017
@pganssle pganssle mentioned this pull request Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add python_requires to setup.py

2 participants