separate out build_naive and build_aware methods#539
Merged
Conversation
Member
|
No immediate objections here. |
pganssle
reviewed
Dec 7, 2017
pganssle
left a comment
pganssle
left a comment
Member
There was a problem hiding this comment.
No objections. I think the last of the sprint PRs that might have had some effect on this are in, so maybe rebase and I'll merge?
jbrockmendel
force-pushed
the
build_methods
branch
from
December 7, 2017 16:53
5b03fef to
40108c4
Compare
Contributor
Author
|
If this goes in I can follow-up with a PR to get test coverage for the one line that is missed. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally I still think these methods should be part of an intermediate results class along the lines of #525, but even in
parserthey are nicely focused.