Skip to content

Pin codecov and py dependencies on Appveyor.#526

Merged
pganssle merged 2 commits into
dateutil:masterfrom
pganssle:pin_codecov
Nov 16, 2017
Merged

Pin codecov and py dependencies on Appveyor.#526
pganssle merged 2 commits into
dateutil:masterfrom
pganssle:pin_codecov

Conversation

@pganssle

Copy link
Copy Markdown
Member

Short-to-medium term fix for #520, until codecov/support#402 is solved in a release to the python codecov client.

@pganssle

Copy link
Copy Markdown
Member Author

Also added a fix for residual issues from pytest-dev/py#169, which is necessary until either the 1.5.0 release is dropped, the trove classifiers get fixed, or whatever test dependencies are including py start pinning on Python 3.3 themselves.

@pganssle pganssle changed the title Pin codecov to 2.0.5 on appveyor builds Pin codecov and py dependencies on Appveyor. Nov 16, 2017
@pganssle
pganssle force-pushed the pin_codecov branch 5 times, most recently from a0fc812 to b055f64 Compare November 16, 2017 18:44
@pganssle

pganssle commented Nov 16, 2017

Copy link
Copy Markdown
Member Author

OK, so while testing this, I realized that we're not being hit by that codecov issue. What was happening was that codecov run -m pytest -v was inferring that the only source was dateutil.test for whatever reason.

By explicitly adding coverage run --source=dateutil -m pytest -v, we get the full report.

Unfortunately, this doesn't actually bring up our coverage at all, because the old erroneous reports from Appveyor were counting dateutil.test twice, and dateutil.test has excellent coverage, as you would expect from a test suite...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant