Skip to content

Fixup extra indentation#492

Merged
pganssle merged 1 commit into
masterfrom
docstring_fixup
Nov 5, 2017
Merged

Fixup extra indentation#492
pganssle merged 1 commit into
masterfrom
docstring_fixup

Conversation

@jbrockmendel

Copy link
Copy Markdown
Contributor

No description provided.

@pganssle

pganssle commented Nov 2, 2017

Copy link
Copy Markdown
Member

This looks fine to me, though it is bringing up that I should look into setting up some sort of CI that builds the documents for us so we can review the final product before merging PRs.

@pganssle

pganssle commented Nov 5, 2017

Copy link
Copy Markdown
Member

@jbrockmendel Going to merge this when CI passes. I tend to not make branches on the dateutil/dateutil repo because 1. the CI fires on both PR and branch, and I don't know how to get it to not do the same work twice and 2. everyone who forks also picks up all the secondary branches. If you prefer to do it this way that's fine, but nowadays maintainers of the primary repo are authorized to push against PR branches, so one of the advantages of working in the main repo is obviated.

@pganssle
pganssle merged commit 6a3f216 into master Nov 5, 2017
@pganssle pganssle added this to the 2.7.0 milestone Nov 5, 2017
@jbrockmendel

Copy link
Copy Markdown
Contributor Author

I tend to not make branches on the dateutil/dateutil repo

I'll make a note of it.

@jbrockmendel
jbrockmendel deleted the docstring_fixup branch November 5, 2017 17:36
@pganssle pganssle mentioned this pull request Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants