Refactor _parse_numeric_token out from the big parsing loop#490
Conversation
|
I'm not totally convinced of the point of this. Now instead of a huge loop body you have a huge function body? Is that really an improvement? |
|
The idea is that it would be really helpful if each step in the loop was just one function call, so we could step through it interactively. Instead of doing that directly, this is just taking one step in that direction by separating out a big chunk of it. We've got a few different threads going in which we're not 100% on the same page. Let's put this on the backburner until we have some concensus-momentum going. |
bbacea4 to
49cd859
Compare
|
@jbrockmendel Hm... I think I may have screwed this up by doing a rebase? There was a merge conflict that I fixed and did a force push, and it broke the |
49cd859 to
bbacea4
Compare
Cut/paste/de-indent.