Refactor new parser functions to keep them in the parser object#468
Merged
Conversation
jbrockmendel
approved these changes
Oct 9, 2017
jbrockmendel
left a comment
jbrockmendel
left a comment
Contributor
There was a problem hiding this comment.
This all looks benign. I'm not as enthusiastic about making everything into methods; it seems unlikely that people will really want to override _parsems or _build_tzinfo. But they're private either way, so not a big deal. LGTM.
Member
Author
|
@jbrockmendel The reason I wanted them all methods is that they are not really reusable outside of the context of the class. There's a case to be made that they might work better as static or class methods, since they don't rely on any state of the instance, but as you said they are private, so the details are not amazingly important. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in my earlier review, this moves all the parsing-related functions back into the
parserobject.