Skip to content

Added 'RRULE:' in rrule.__str__ to be RFC compliant#450

Merged
pganssle merged 1 commit into
dateutil:masterfrom
mlorant:rrule_str_86
Aug 17, 2017
Merged

Added 'RRULE:' in rrule.__str__ to be RFC compliant#450
pganssle merged 1 commit into
dateutil:masterfrom
mlorant:rrule_str_86

Conversation

@mlorant

@mlorant mlorant commented Aug 17, 2017

Copy link
Copy Markdown
Contributor

Fixes #86 ; courtesy to @jarondl for the initial patch

@pganssle

Copy link
Copy Markdown
Member

OK, I think this is fine.

@pganssle pganssle added the rrule label Aug 17, 2017
@pganssle pganssle added this to the 2.7.0 milestone Aug 17, 2017
@pganssle

Copy link
Copy Markdown
Member

@mlorant Sorry, I should be more enthusiastic - thank you for your contribution to dateutil! This issue has been open for a while and had fallen off my radar a bit, but it's good to get us up to standards-compliance here.

I'm going to go ahead and merge this for the next feature release (2.7.0), we'll see if anyone downstream picking up our changes was relying on the old behavior.

@pganssle
pganssle merged commit 2f3a160 into dateutil:master Aug 17, 2017
@pganssle pganssle mentioned this pull request Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants