Skip to content

Protect tzical cache with a lock (fixes #428)#430

Merged
pganssle merged 1 commit into
dateutil:masterfrom
Unrud:patch-2
Jul 29, 2017
Merged

Protect tzical cache with a lock (fixes #428)#430
pganssle merged 1 commit into
dateutil:masterfrom
Unrud:patch-2

Conversation

@Unrud

@Unrud Unrud commented Jul 27, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@Unrud Unrud changed the title Protect tzutil cache with a lock (fixes #428) Protect tzical cache with a lock (fixes #428) Jul 27, 2017
@pganssle

Copy link
Copy Markdown
Member

Hm.. This isn't really how I want to fix this (I am planning on ripping out a lot of the cache stuff from tzical anyway and replacing it), but if we get close to a new release and I still haven't followed up on #342, I'll accept this.

@Unrud

Unrud commented Jul 27, 2017

Copy link
Copy Markdown
Contributor Author

Hm.. This isn't really how I want to fix this

This was meant as a provisional fix, until the rewrite is completed.

@pganssle

Copy link
Copy Markdown
Member

@Unrud Yeah. I don't think we're going to do any more bugfix releases for the 2.6.0 branch, but if I don't fix caches before the 2.7.0 release I'll merge this.

@pganssle

Copy link
Copy Markdown
Member

Actually, this has no changes to the public interface, so I can always just rip it out later if I need to change it. Doesn't hurt to merge it.

@pganssle
pganssle merged commit 94f1639 into dateutil:master Jul 29, 2017
@pganssle pganssle mentioned this pull request Mar 11, 2018
@pganssle pganssle added this to the 2.7.0 milestone Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants