Separate out "while True" loop for e.g. 12 h00m04s#425
Closed
jbrockmendel wants to merge 4 commits into
Closed
Conversation
Member
|
This assumes #419 is merged, correct? |
Contributor
Author
|
I think I wrote it separately on the assumption I'd rebase when the time came. |
Member
|
Superceded by #436 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
whileloop that currently handles things like "12 h00m04s" is one of the hardest pieces of the parser to reason about. This is in part because it tries to capture all of these tokens in one pass. This PR implements a version that allows for looking backwards, so each of the ["12", "00", "04"] gets individually processed.This also handles the lookback previously at L793.
Last, a tox testenv is added for lightweight testing of just the parser.