Fix incorrect index check, add test that fails pre-PR by jbrockmendel · Pull Request #420 · dateutil/dateutil

jbrockmendel · 2017-07-18T01:23:12Z

In the status-quo, L824-825 checks:

                        if i < len_l and l[i] == ':':
                            res.second, res.microsecond = _parsems(l[i+1])

Avoiding an IndexError requires checking i+1 < len_l. This is easy to miss because the try/except catches IndexError. One way to trigger this is:

import dateutil.parser
dateutil.parser.IndexError = SyntaxError
dateutil.parser.parse('2017-07-17 06:21:', fuzzy=True)

pganssle · 2017-07-18T02:35:14Z

Ugh, this giant try/catch block really has to go.

Fix incorrect index check, add test that fails pre-PR

0b773a5

pganssle added bug parser labels Jul 18, 2017

pganssle added this to the 2.7.0 milestone Jul 18, 2017

pganssle merged commit 7f9d40a into dateutil:master Jul 18, 2017

jbrockmendel deleted the fix_idxcheck branch July 18, 2017 03:11

pganssle mentioned this pull request Mar 11, 2018

Release 2.7.0 #627

Closed

Provide feedback