Fix timelex#122
Merged
Merged
Conversation
Member
|
I like where this is going, but I think we're actually losing some flexibility by enforcing That said, I think that this is the right default approach. Today I'll make a PR against your branch with a suggested improvement. |
Member
|
@jarondl This seems like a major change - any thoughts on the matter? See also my PR at ms-boom/dateutil#1 |
Member
|
I'm going to go ahead and merge this. We can always undo it later if it causes some significant problems. |
Member
aschatten
pushed a commit
to aschatten/dateutil
that referenced
this pull request
Nov 16, 2015
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix wrong tokens on unicode string