Issue#1167 add doc note and tests around things of last day of month actual desired behavior#1170
Merged
Merged
Conversation
Mifrill
changed the title
Contributor
Author
Contributor
Author
|
Hi, @pganssle could you review it, please? |
Contributor
Author
|
Hey @pganssle any chance to have it merged? |
Contributor
Author
|
@pganssle ping |
Member
|
Sorry, I have very little time for OSS these days and there are many other things on my to do list. I appreciate that it sucks to have your PRs languish on under-maintained libraries, but you don't need to keep pinging me. I or someone else will review this before the next release, which won't be for a while. |
mariocj89
requested changes
Oct 11, 2021
dateutil#1170 (comment) Co-authored-by: Mario Corchero <[email protected]>
mariocj89
approved these changes
Oct 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Added doc and tests to reflect the actual desired behavior around last day of month things.
Closes #1167
Pull Request Checklist