Skip to content

Add formatDuration function#1671

Merged
kossnocorp merged 66 commits intomasterfrom
format-duration
May 10, 2020
Merged

Add formatDuration function#1671
kossnocorp merged 66 commits intomasterfrom
format-duration

Conversation

@kossnocorp
Copy link
Copy Markdown
Member

@kossnocorp kossnocorp commented Mar 14, 2020 •
edited
Loading

Add formatDuration function that allows formatting Duration object as a human-readable string, i.e.:

formatDuration({ years: 0, months: 9 })
//=> '9 months'

formatDuration({ years: 0, months: 9 }, null, { zero: true })
//=> '0 years 9 months'

formatDuration({ years: 2, months: 9, weeks: 3 }, { delimiter: ', ' })
//=> '2 years, 9 months, 3 weeks'

A big part of this pull-request is adding weeks to locale's formatDistance. Meaning we have to update every locale before we can ship this PR 😱

🚧 Locales to update

  • Afrikaans af locale
  • Arabic ar-DZ locale (Algeria)
  • Arabic ar-MA locale (Moroccan)
  • Arabic ar-SA locale (Sauid Arabic)
  • Azerbaijani az locale
  • Bulgarian bg locale
  • Bengali bn locale
  • Catalan ca locale
  • Czech cs locale
  • Welsh cy locale
  • Danish da locale
  • German de locale
  • Greek el locale
  • English en-AU locale (Australia)
  • English en-CA locale (Canada)
  • English en-GB locale (UK)
  • English en-US locale (USA)
  • Esperanto eo locale
  • Spanish es locale
  • Estonian et locale
  • Persian/Farsi fa-IR locale (Iran)
  • Finnish fi locale
  • French fr locale
  • French fr-CA locale (Canada)
  • Galician gl locale
  • Gujarati gu locale
  • Hebrew he locale
  • Hindi hi locale
  • Croatian hr locale
  • Hungarian hu locale
  • Armenian hy locale
  • Indonesian id locale
  • Icelandic is locale
  • Italian it locale
  • Japanese ja locale
  • Georgian ka locale
  • Kazakh kk locale
  • Korean ko locale
  • Lithuanian lt locale
  • Latvian lv locale
  • Macedonian mk locale
  • Malay ms locale
  • Maltese mt locale
  • Norwegian Bokmål nb locale
  • Dutch nl locale
  • Norwegian Nynorsk nn locale
  • Polish pl locale
  • Portuguese bt-BR locale (Brazil)
  • Romanian ro locale
  • Russian ru locale
  • Slovak sk locale
  • Slovenian sl locale
  • Serbian cyrillic sr locale
  • Serbian latin sr-Latn locale
  • Swedish sv locale
  • Tamil ta locale (India)
  • Telugu te locale
  • Thai th locale
  • Turkish tr locale
  • Uighur ug locale
  • Ukrainian uk locale
  • Uzbek uz locale
  • Vietnamese vi locale
  • Chinese Simplified zh-CN locale
  • Chinese Traditional zh-TW locale

kossnocorp
kossnocorp commented Mar 14, 2020
View reviewed changes
Comment thread src/locale/ar-SA/_lib/formatDistance/index.js
threeToTen: '{{count}} أشهر', // TODO
other: '{{count}} شهر' // TODO
},

Copy link
Copy Markdown
Member Author

@kossnocorp kossnocorp Mar 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@date-fns/i18n-ar-dz @date-fns/i18n-ar-sa hey, we're adding weeks to formatDistance. Please take a look 🙏 It shouldn't take more than a few minutes. Thanks!

Copy link
Copy Markdown
Member

@dalwadani dalwadani May 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arabic ar-SA locale (Sauid Arabia) is done.

kossnocorp
kossnocorp commented Mar 14, 2020
View reviewed changes
Comment thread src/locale/ar-MA/_lib/formatDistance/index.js
threeToTen: '{{count}} أشهر', // TODO
other: '{{count}} شهر' // TODO
},

Copy link
Copy Markdown
Member Author

@kossnocorp kossnocorp Mar 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@date-fns/i18n-ar-dz @date-fns/i18n-ar-sa hey, we're adding weeks to formatDistance. Please take a look 🙏 It shouldn't take more than a few minutes. Thanks!

kossnocorp
kossnocorp commented Mar 14, 2020
View reviewed changes
Comment thread src/locale/ar-DZ/_lib/formatDistance/index.js Outdated
threeToTen: '{{count}} أشهر', // TODO
other: '{{count}} شهر' // TODO
},

Copy link
Copy Markdown
Member Author

@kossnocorp kossnocorp Mar 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@date-fns/i18n-ar-dz @date-fns/i18n-ar-sa hey, we're adding weeks to formatDistance. Please take a look 🙏 It shouldn't take more than a few minutes. Thanks!

kossnocorp
kossnocorp commented Apr 15, 2020
View reviewed changes
Copy link
Copy Markdown
Member Author

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we can merge it, we have to update all v2 locales.

Comment thread src/locale/af/_lib/formatDistance/index.js
Comment thread src/locale/az/_lib/formatDistance/index.js
Comment thread src/locale/bg/_lib/formatDistance/index.js
Comment thread src/locale/bn/_lib/formatDistance/index.js
Comment thread src/locale/ca/_lib/formatDistance/index.js
Comment thread src/locale/uk/_lib/formatDistance/index.js
Comment thread src/locale/uz/_lib/formatDistance/index.js
Comment thread src/locale/vi/_lib/formatDistance/index.js
Comment thread src/locale/zh-CN/_lib/formatDistance/index.js
Comment thread src/locale/zh-TW/_lib/formatDistance/index.js
one: '1 個月', // TODO
other: '{{count}} 個月' // TODO
},

Copy link
Copy Markdown
Member Author

@kossnocorp kossnocorp Apr 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@date-fns/i18n-zh-tw hey, we're adding weeks to formatDistance. Please take a look 🙏 It shouldn't take more than a few minutes. Thanks!

@kossnocorp
Copy link
Copy Markdown
Member Author

kossnocorp commented Apr 15, 2020

Please forgive me for spamming, but I couldn't find any better way to handle this. I hope you didn't receive every comment as a separate email. If so, I'm double sorry and RIP your inbox.

@emil9453
Copy link
Copy Markdown
Contributor

emil9453 commented Apr 15, 2020 via email

imballinst
imballinst reviewed Apr 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@imballinst imballinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kossnocorp added my suggestions related to the id locale. Thanks for the kind notification!

Comment thread src/locale/id/_lib/formatDistance/index.js
Comment thread src/locale/id/_lib/formatDistance/index.js
teoulas
teoulas reviewed Apr 15, 2020
View reviewed changes
Comment thread src/locale/el/_lib/formatDistance/index.js Outdated
teoulas
teoulas reviewed Apr 15, 2020
View reviewed changes
Comment thread src/locale/el/_lib/formatDistance/index.js Outdated
kgram
kgram reviewed Apr 15, 2020
View reviewed changes
Comment thread src/locale/da/_lib/formatDistance/index.js
izeau
izeau reviewed Apr 15, 2020
View reviewed changes
Comment thread src/locale/fr/_lib/formatDistance/index.js
Comment thread src/locale/fr-CH/_lib/formatDistance/index.js
abduwaly
abduwaly reviewed Apr 15, 2020
View reviewed changes
Comment thread src/locale/ug/_lib/formatDistance/index.js
@kbrabrand
Copy link
Copy Markdown
Contributor

kbrabrand commented Apr 15, 2020 •
edited
Loading

@kossnocorp Was a bit unsure how you wanted this, but I've fixed the Norwegian locales (nb and nn) by pushing commits to the PR branch, and updated your PR comment.

ykzts
ykzts reviewed Apr 15, 2020
View reviewed changes
Comment thread src/locale/ja/_lib/formatDistance/index.js
@kossnocorp
Copy link
Copy Markdown
Member Author

kossnocorp commented Apr 15, 2020

@kbrabrand that's perfect, thank you!

abduwaly
abduwaly reviewed Apr 16, 2020
View reviewed changes
Comment thread src/locale/uz/_lib/formatDistance/index.js
@Pyppe
Copy link
Copy Markdown
Contributor

Pyppe commented Apr 16, 2020

Added Finnish locale in 353d0db

albertorestifo
albertorestifo reviewed Apr 16, 2020
View reviewed changes
Comment thread src/locale/it/_lib/formatDistance/index.js Outdated
Comment thread src/locale/it/_lib/formatDistance/index.js Outdated
Comment thread src/locale/it/_lib/formatDistance/index.js Outdated
Comment thread src/locale/it/_lib/formatDistance/index.js Outdated
@iamssen iamssen mentioned this pull request Apr 16, 2020
Closed
@sibiraj-s
Copy link
Copy Markdown
Member

sibiraj-s commented Apr 16, 2020 •
edited
Loading

@kossnocorp here for tamil locale #1725

@iamssen iamssen mentioned this pull request Apr 18, 2020
Merged
@ThamosIO ThamosIO mentioned this pull request Apr 21, 2020
Merged
gpetrioli
gpetrioli previously approved these changes Apr 22, 2020
View reviewed changes
@gpetrioli gpetrioli dismissed their stale review April 22, 2020 14:36

was accidental, i wanted to approve a single commit

@kossnocorp
Copy link
Copy Markdown
Member Author

kossnocorp commented May 10, 2020

Thanks, everyone for helping, I finally finished all locales (some with the help of Google Translate, so thanks to it as well!)!

You're all awesome, have a great weekend!

ThamosIO and others added 22 commits May 10, 2020 13:45
@ThamosIO @kossnocorp
Add weeks to Italian formatDistance (#1737)
d1d4fb7
@bryanMt @kossnocorp
Added weeks for maltese locale (#1736)
92dfd76 
Co-authored-by: brbo01 <[email protected]>
@sibiraj-s @kossnocorp
Update weeks formatting in Tamil locale (#1725)
d2aadad
@ManadayM @kossnocorp
fix(formatDistance): gu locale for aboutXWeeks and xWeeks (#1732)
edf8495
@derekblank @kossnocorp
Add weeks to Croatian locale (#1738)
f220874
@dalwadani @kossnocorp
fix weeks string for formatDuration (ar-SA)
1bb3d70
@aocneanu @kossnocorp
adds for weeks support in ro translation (formatDistance)
fd600b4
@kossnocorp
Update ar-DZ and ar-MA
4406ea3
@kossnocorp
Update fa-IR
9c46896
@kossnocorp
Update hi locale
8100536
@kossnocorp
Update hy locale
cbe0513
@kossnocorp
Update ka locale
f98d32f
@kossnocorp
Update lt locale
8620abe
@kossnocorp
Update mk locale
7c917ec
@kossnocorp
Update zh-TW locale
67ad319
@kossnocorp
Add tr locale
0f03f9f
@kossnocorp
Add Telugu locale
875b8f1
@kossnocorp
Add Serbian locale
88484f6
@kossnocorp
Add Slovenian locale
6cc12ed
@kossnocorp
Add Latvian locale
db341e9
@kossnocorp
Fix Polish locale
adc99be
@kossnocorp
Build the library
4555752
@kossnocorp kossnocorp merged commit 2108814 into master May 10, 2020
@kossnocorp kossnocorp deleted the format-duration branch May 10, 2020 11:01
This was referenced May 11, 2020
Merged
Closed
This was referenced Jul 22, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fidelpita fidelpita fidelpita left review comments

@mareksuscak mareksuscak mareksuscak left review comments

@piotrd piotrd piotrd left review comments

@ykzts ykzts ykzts left review comments

@nodtem66 nodtem66 nodtem66 left review comments

@trongthanh trongthanh trongthanh left review comments

@ManadayM ManadayM ManadayM left review comments

@touhidrahman touhidrahman touhidrahman left review comments

@derekblank derekblank derekblank left review comments

@izeau izeau izeau left review comments

@vin-car vin-car vin-car left review comments

@albertorestifo albertorestifo albertorestifo left review comments

@wregis wregis wregis left review comments

@kbrabrand kbrabrand kbrabrand left review comments

@curry684 curry684 curry684 left review comments

@drugoi drugoi drugoi left review comments

@elmomalmo elmomalmo elmomalmo left review comments

@teoulas teoulas teoulas left review comments

@davidrus davidrus davidrus left review comments

@fintara fintara fintara left review comments

@abduwaly abduwaly abduwaly left review comments

@dalwadani dalwadani dalwadani left review comments

@tunnckoCore tunnckoCore tunnckoCore left review comments

@harogaston harogaston harogaston left review comments

@imballinst imballinst imballinst left review comments

@kgram kgram kgram left review comments

@cubicwork cubicwork cubicwork left review comments

@justrag justrag justrag left review comments

@avizcaino avizcaino avizcaino left review comments

@TwoDCube TwoDCube TwoDCube left review comments

@jsergiu jsergiu jsergiu approved these changes

@gpetrioli gpetrioli gpetrioli left review comments

+1 more reviewer

@bryanMt bryanMt bryanMt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🎉 Feature #265d21 🌏 I18n

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.