Invoke-DbaAdvancedRestore - Fix for proper progress bar display#4454
Merged
potatoqualitee merged 11 commits intodataplat:developmentfrom Nov 9, 2018
olegstrutinskii:development
Merged
Invoke-DbaAdvancedRestore - Fix for proper progress bar display#4454potatoqualitee merged 11 commits intodataplat:developmentfrom olegstrutinskii:development
potatoqualitee merged 11 commits intodataplat:developmentfrom
olegstrutinskii:development
Conversation
Updating frok
Updating fork
Update Fork
Fork update
Updating fork
Updating Fork
Rdd progress update from development
Member
|
Fantastic!! I've been looking forward to this one for a while, thanks so much @zhunya ! Looking fwd to the review from Stuart or Niph |
olegstrutinskii
changed the title
Member
|
Arrgh, so sorry, I thought I was on my PR. I'll do a bunch of testing to ensure this works, the code makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Purpose
Somehow progress bar was broken
Approach
Fixed progress ID parenthesis and proper completing
Some 'house cleaning' included too
Commands to test
Restore any database with Restore-DbaDatabase
Screenshots