Get-DbaNetworkConfiguration: Fix bug and really add SuitableCertificate property to output#10165
Merged
potatoqualitee merged 3 commits intodevelopmentfrom Feb 16, 2026
Merged
Get-DbaNetworkConfiguration: Fix bug and really add SuitableCertificate property to output#10165potatoqualitee merged 3 commits intodevelopmentfrom
potatoqualitee merged 3 commits intodevelopmentfrom
Conversation
10 tasks
Collaborator
Author
|
Test works in my lab: |
Collaborator
Author
|
Test only fails on old AppVeyor image, maybe because certificate can not be created. So we only run the test on new image. |
Member
|
thank you, appveyor can be such a bummer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Invoke-ManualPester)I completely overlooked the fact that the new property doesn't end up in the output at all.
But now...
And with testing...