Remove-DbaDbLogShipping - Fix handling of incomplete log shipping configurations#10123
Merged
potatoqualitee merged 1 commit intodevelopmentfrom Jan 30, 2026
Merged
Conversation
…figurations Fixes #10122 Changes: - Changed INNER JOIN to LEFT JOIN in log shipping info query to detect incomplete configurations - Added logic to handle primary-only configurations (no secondary setup) - Wrapped all secondary-related operations in conditional blocks based on $hasSecondary variable - Added verbose message when only primary configuration exists - Added test coverage for incomplete log shipping scenario This resolves the issue where Remove-DbaDbLogShipping failed with "Could not retrieve log shipping information" when the secondary configuration was missing (e.g., Azure Managed Instance partial setup). (do Remove-DbaDbLogShipping) Co-authored-by: Chrissy LeMaire <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10122
This PR fixes
Remove-DbaDbLogShippingto properly handle incomplete log shipping configurations where the secondary database setup is missing. This can occur when log shipping setup fails partway through (e.g., Azure Managed Instance which doesn't support log shipping).Changes
Test Plan
Added integration test that:
(do Remove-DbaDbLogShipping)
🤖 Generated with Claude Code