Update Copy-DbaInstanceAudit.ps1 - bug 10113#10116
Merged
potatoqualitee merged 4 commits intodataplat:developmentfrom Jan 29, 2026
Merged
Update Copy-DbaInstanceAudit.ps1 - bug 10113#10116potatoqualitee merged 4 commits intodataplat:developmentfrom
potatoqualitee merged 4 commits intodataplat:developmentfrom
Conversation
Path is only needed to be tested when using audit to file, other types like security log, app log, url, external monitor we don't need to check the path
public/Copy-DbaInstanceAudit.ps1
Outdated
| $rootUnc = Join-AdminUnc $resolvedComputerName $root | ||
|
|
||
| if ((Test-Path $rootUnc) -eq $true) { | ||
| if ((Test-Path $rootUnc) -eq $true ) { |
Collaborator
There was a problem hiding this comment.
Please remove that new space.
andreasjordan
approved these changes
Jan 27, 2026
Collaborator
andreasjordan
left a comment
andreasjordan
left a comment
There was a problem hiding this comment.
Thanks for fixing this bug.
Member
|
thank you both, and thank you for the approval andreas 🙏🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path is only needed to be tested when using audit to file, other types like security log, app log, url, external monitor we don't need to check the path
Type of Change
Invoke-ManualPester)Purpose
Fix substring errors when copying audits which don't go to files
Approach
Checks the destination type and only checks file path on file dest types
Commands to test
Screenshots
Works with -force but throws errors about test-path and substring
After modification, checking the test-path for only $surrentAudit.DestinationType -eq "File" works in both Force and Non-Forced modes
Learning