Get-DbaService: Add property SqlInstance when using parameter AdvancedProperties to support Failover Cluster Instances#10082
Merged
potatoqualitee merged 3 commits intodevelopmentfrom Jan 7, 2026
Conversation
potatoqualitee
requested changes
Jan 6, 2026
Member
|
awesome thank you 🙇🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Invoke-ManualPester)Purpose
I need this later for a refctoring of Test-DbaDiskAllocation.
When working with failover cluster instances, the VSName (virtual server name / network name) is needed to connect to the instance instead of the computername that is output by Get-DbaService as the computername is resolved from the input. So
Get-DbaService -SqlInstance FCI01will output "SQL01" as the computername if the instance is currently running on that computer.Approach
When using the parameter AdvancedProperties, the needed information is retrieved, but not well formatted. I changed the code so that for the engine service the SqlInstance property is calculated like in most of our other commands.