Some more test fixes to support remote instances#10060
Merged
potatoqualitee merged 5 commits intodevelopmentfrom Dec 25, 2025
Merged
Some more test fixes to support remote instances#10060potatoqualitee merged 5 commits intodevelopmentfrom
potatoqualitee merged 5 commits intodevelopmentfrom
Conversation
Collaborator
Author
|
Will work on this tomorrow... |
Collaborator
Author
|
Running more tests now, so more commits will be added... |
Collaborator
Author
|
Ready to be reviewed and merged... |
| } | ||
| } | ||
| $results = Test-DbaSpn -ComputerName $env:COMPUTERNAME -WarningAction SilentlyContinue | ||
| $results = Test-DbaSpn -ComputerName $TestConfig.instance1 |
Member
There was a problem hiding this comment.
🤔 how did this pass on appveyor?
Collaborator
Author
Collaborator
Author
There was a problem hiding this comment.
I think this test is only usefull in a bigger test environment with a domain and kerberos like I have it in my lab.
| $null = Invoke-DbaQuery -SqlInstance $instance -Database tempdb -Query $dropTableQuery | ||
| } | ||
|
|
||
| $null = Remove-DbaLogin -SqlInstance $TestConfig.instance1, $TestConfig.instance2 -Login 'claudio', 'port', 'tester' |
Collaborator
Author
There was a problem hiding this comment.
No. Initialize-TestLogin removes all the test logins. So there are no more logins to removeand so this command only outputs a warning about not finding those logins. I capture all the warnings while running the tests so I found this and removed all the code that does no work but only outputs warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This will not be the last pr as these tests still fail:
Get-DbaExternalProcess.Tests.ps1
Import-DbaCsv.Tests.ps1
Stop-DbaExternalProcess.Tests.ps1
I will try to work on those the next days.