Skip to content

Comments

Some more test fixes to support remote instances#10060

Merged
potatoqualitee merged 5 commits intodevelopmentfrom
more_test_fixes
Dec 25, 2025
Merged

Some more test fixes to support remote instances#10060
potatoqualitee merged 5 commits intodevelopmentfrom
more_test_fixes

Conversation

@andreasjordan
Copy link
Collaborator

@andreasjordan andreasjordan commented Dec 22, 2025

This will not be the last pr as these tests still fail:

  • Get-DbaExternalProcess.Tests.ps1

  • Import-DbaCsv.Tests.ps1

  • Stop-DbaExternalProcess.Tests.ps1

I will try to work on those the next days.

@andreasjordan
Copy link
Collaborator Author

Will work on this tomorrow...

@andreasjordan
Copy link
Collaborator Author

Running more tests now, so more commits will be added...

@andreasjordan
Copy link
Collaborator Author

Ready to be reviewed and merged...

}
}
$results = Test-DbaSpn -ComputerName $env:COMPUTERNAME -WarningAction SilentlyContinue
$results = Test-DbaSpn -ComputerName $TestConfig.instance1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 how did this pass on appveyor?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On AppVeyor this is the output:

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test is only usefull in a bigger test environment with a domain and kerberos like I have it in my lab.

$null = Invoke-DbaQuery -SqlInstance $instance -Database tempdb -Query $dropTableQuery
}

$null = Remove-DbaLogin -SqlInstance $TestConfig.instance1, $TestConfig.instance2 -Login 'claudio', 'port', 'tester'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are they left behind?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Initialize-TestLogin removes all the test logins. So there are no more logins to removeand so this command only outputs a warning about not finding those logins. I capture all the warnings while running the tests so I found this and removed all the code that does no work but only outputs warnings.

@potatoqualitee potatoqualitee merged commit 4bece0e into development Dec 25, 2025
24 checks passed
@potatoqualitee potatoqualitee deleted the more_test_fixes branch December 25, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants