Sync-DbaLoginPermission - Fix login disabled state not being synced#10007
Merged
potatoqualitee merged 1 commit intodevelopmentfrom Nov 30, 2025
Merged
Sync-DbaLoginPermission - Fix login disabled state not being synced#10007potatoqualitee merged 1 commit intodevelopmentfrom
potatoqualitee merged 1 commit intodevelopmentfrom
Conversation
(do Sync-DbaLoginPermission) Co-authored-by: Chrissy LeMaire <[email protected]>
Collaborator
|
Sorry to say: Tests fail in my test lab because code is not working. "'IsDisabled' is a ReadOnly property" is totally correct. We need to use the The test has a problem on AppVeyor so it looks like it passed, but it was not executed correctly. We can not trust the AppVeyor test! |
Merged
10 tasks
Member
Author
|
Thank you for running this through your system. I'll address this now 🙏🏼 |
Member
Author
|
oh, your previous PR did, whoops, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9208 - Sync-DbaLoginPermission now properly syncs login enabled/disabled state from source to destination.
Changes
Update-SqlPermission.ps1to sync theIsDisabledproperty of loginsTesting
New integration test verifies that when a login is disabled on source, it is properly disabled on destination after running Sync-DbaLoginPermission.
Generated with Claude Code