Merged
Conversation
3.8 EOLed earlier this year, and even oldoldstable Debian has 3.9 . Time to start use := throughout ;-)
after 3.14 there is change of signature in the function and those patches are even picked up into debian 3.12 version thus breaking the code here, and in effect disabling load of commands from extensions. For a more general fix on not picking up during early parsing failure: datalad#7679 and the underlying issue: datalad#7678
yarikoptic
added
semver-patch
2 tasks
github-actions
bot
removed
the
CHANGELOG-missing
Member
Author
|
yikes - filed
|
Unclear why but we get odd PATH pointing to some lib/jvm within conda, and thus failing to find pytest.
PATH=/home/runner/work/datalad/datalad/__testhome__/../tools/coverage-bin:/tmp/dl-miniconda-tgsq43n2/lib/jvm/languages/python/bin:/tmp/dl-miniconda-tgsq43n2/condabin:/opt/hostedtoolcache/Python/3.10.15/x64/bin:/opt/hostedtoolcache/Python/3.10.15/x64:/snap/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
+ python -m pytest -v -c ../tox.ini -n 2 -m 'not(turtle)' --doctest-modules --cov=datalad --cov-report=xml --pyargs datalad
/tmp/dl-miniconda-tgsq43n2/lib/jvm/languages/python/bin/python: No module named pytest
yarikoptic
force-pushed
the
rf-drop3.8
branch
from
39e606c to
6f356b7
Compare
Underlying issue is with 7.6.5: reported to coveragepy/coveragepy#1891 . First 7.6.1 was tried and it worked. Next bisection is 7.6.3 was ok. nedbat clarified that indeed in 7.6.5 some assertions were added: coveragepy/coveragepy#1891 (comment) So we will just keep it that ceiled until issue resolved.
isntallation from .deb for that elderly version iirc is not possible since depends on missing in that ubuntu libffi7 or smth like that
yarikoptic
force-pushed
the
rf-drop3.8
branch
from
6f356b7 to
d28e5f1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maint #7682 +/- ##
==========================================
- Coverage 91.59% 90.90% -0.70%
==========================================
Files 324 324
Lines 43142 43142
Branches 5770 4934 -836
==========================================
- Hits 39518 39219 -299
- Misses 3610 3909 +299
Partials 14 14 ☔ View full report in Codecov by Sentry. |
Member
Author
|
oh, one brew is left, will do separately -- unrelated to this PR. So I will just proceed. |
Collaborator
|
PR released in |
yarikoptic
added a commit
that referenced
this pull request
Dec 13, 2024
"snapshot" method is installing into a temp folder and we would need to setup env var file to source etc. I have introduced that change in recent #7682 and missed that for that original commit appveyor did fail, and subsequent commit af2bd74 CI run had only OSX brew fail which made me think appveyor is ok, but apparently it was not there at all! So I missed that failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Individual commits have a little more to say.
intermixed#7678We should release either with this or #7679 to fix #7678 which renders extensions unusable on debian ATM.
TODOs