fix: do load extension interfaces if early parsing errors out#7679
Merged
yarikoptic merged 2 commits intodatalad:maintfrom Nov 18, 2024
Merged
fix: do load extension interfaces if early parsing errors out#7679yarikoptic merged 2 commits intodatalad:maintfrom
yarikoptic merged 2 commits intodatalad:maintfrom
Conversation
Member
Author
|
mac, seems some legitish issue, filed
|
yarikoptic
added
the
merge-if-ok
yarikoptic
added a commit
to yarikoptic/datalad
that referenced
this pull request
Nov 14, 2024
after 3.14 there is change of signature in the function and those patches are even picked up into debian 3.12 version thus breaking the code here, and in effect disabling load of commands from extensions. For a more general fix on not picking up during early parsing failure: datalad#7679 and the underlying issue: datalad#7678
yarikoptic
added
CHANGELOG-missing
github-actions
bot
removed
the
CHANGELOG-missing
Member
Author
|
I will also rebase now ... |
Apparently we have not been loading them upon error in early parsing. Debian has python 3.12 patched with some patches from what came after 3.14 (!) and that broke that interface. We silently just did not even try to get those parsers in place. With this change we would
yarikoptic
force-pushed
the
bf-extensions
branch
from
a3189fd to
1b3c966
Compare
Member
Author
|
Appveyer strikes again... Uff. Unrelated to these changes so I consider merging as is and later liking at it again. Will do tomorrow if no objections |
Collaborator
|
PR released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently we have not been loading them upon error in early parsing. Debian has python 3.12 patched with some patches from what came after 3.14 (!) and that broke that interface. We silently just did not even try to get those parsers in place. With this change we would
TODOs
add a fix to actually use that new-- we seems just need to drop 3.8 and stop using the protected method there -- will do separate PR! That would also unblock testing datalad-neuroimaging which dropped 3.8 alreadyintermixedflagIn effect fixes datalad-container namespace is not picked up due to missing required
intermixed#7678