Skip to content

feat(assertions): Update popover, Status pill, and integrate severity#17355

Merged
AdrianMachado merged 4 commits into
datahub-project:masterfrom
AdrianMachado:updatePopover
May 8, 2026
Merged

feat(assertions): Update popover, Status pill, and integrate severity#17355
AdrianMachado merged 4 commits into
datahub-project:masterfrom
AdrianMachado:updatePopover

Conversation

@AdrianMachado
Copy link
Copy Markdown
Contributor

@AdrianMachado AdrianMachado commented May 8, 2026

Summary

  • Broke down the AssertionResultPopoverContext into subcomponent to make it easier to read and maintain
    • Also added a new severity section
  • Cleaned up fetching in the AssertionResultsTable
  • AssertionResultsTableItem now uses AssertionResultPill to display status
  • AssertionResultPill now features the severity as an icon

Preview

Screen.Recording.2026-05-07.at.7.56.36.PM.mov

@AdrianMachado AdrianMachado requested a review from jayacryl May 8, 2026 02:57
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Linear: OBS-1824

@github-actions github-actions Bot added the product PR or Issue related to the DataHub UI/UX label May 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Bundle Report

Changes will increase total bundle size by 4.06kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 22.98MB 4.06kB (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 4.06kB 8.65MB 0.05%

Files in assets/index-*.js:

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/assertion/profile/summary/shared/assertionResultSeverityUtils.ts → Total Size: 568 bytes

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/assertion/profile/summary/shared/AssertionResultPill.tsx → Total Size: 1.17kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/assertion/profile/summary/shared/resultMessageUtils.ts → Total Size: 2.61kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/assertion/profile/summary/result/table/AssertionResultsTable.tsx → Total Size: 1.98kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/assertion/profile/shared/result/AssertionResultPopoverContent.tsx → Total Size: 7.8kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/assertion/profile/summary/result/table/AssertionResultsTableItem.tsx → Total Size: 2.43kB

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Your PR has been assigned to @jayacryl (jay.patel) for review (OBS-1824).

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 36.36364% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ile/summary/shared/assertionResultSeverityUtils.ts 33.33% 12 Missing ⚠️
...rtion/profile/summary/shared/resultMessageUtils.ts 50.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (36.36%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@maggiehays maggiehays added the needs-review Label for PRs that need review from a maintainer. label May 8, 2026
@AdrianMachado AdrianMachado merged commit 02387e5 into datahub-project:master May 8, 2026
55 of 58 checks passed
@AdrianMachado AdrianMachado deleted the updatePopover branch May 8, 2026 17:30
david-leifker pushed a commit that referenced this pull request May 27, 2026
Merge 02387e5: feat(assertions): Update popover, Status pill, and int…
5cc37dc 
…egrate severity (#17355)

Conflicts resolved by Claude AI.

Merged from commit 02387e5
Original author: Adrian Machado <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jayacryl jayacryl jayacryl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AdrianMachado @jayacryl @maggiehays