fix(vertica): remove accidental pytest import from source file#16763
Merged
Conversation
github-actions
Bot
added
the
ingestion
Contributor
|
Linear: ING-2056 |
kyungsoo-datahub
approved these changes
Mar 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
Your PR has been assigned to @kyungsoo-datahub (kyungsoo.lee) for review (ING-2056). |
Connector Tests ResultsAll connector tests passed for commit To skip connector tests, add the Autogenerated by the connector-tests CI pipeline. |
david-leifker
pushed a commit
that referenced
this pull request
May 27, 2026
- docs(free trials): updating free trial links (#16758) - docs(readme): Add link for Free Cloud Trial on Readme (#16753) - fix(vertica): remove accidental pytest import from source file (#16763) - docs(readme): Remove Roadmap link from README (#16765) - chore(tests/mssql): update formatting of golden files (#16735) - feat(ingest/powerbi): support 'Sql.Databases' M-Query data access function (#16616) - fix(ingest/mssql): lowercase field paths when convert_urns_to_lowercase=True (#16736) - feat(cli): add `datahub init --sso` for browser-based SSO login (#16715) - feat(cli): add --context / -C flag for passing context in event properties (#16764) - build(ingest): bump python-liquid from <2 to >=2.0.0,<3.0.0 (#16697) - chore(docs): Update docs for summary pages, multiple data products, and ingestion (#16584)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Remove
import pytestandpytestmarkthat were accidentally placed in the Vertica source file instead of the test file.🎯 Motivation
The
validate-plugin-depsCI job installs each plugin in an isolated venv and then verifies it is importable viadatahub check plugins --source <plugin>. The Vertica plugin was failing this check becausevertica.pyimportspytestat module level — a test-only dependency that is not (and should not be) declared in theverticaextras.This was a latent bug that went undetected until the import-check step was added to CI (#16749).
🔧 Changes Overview
Bug Fix:
import pytestfromvertica.py(line 7)pytestmark = pytest.mark.integration_batch_4fromvertica.py(line 60)The
pytestmarkmarker belongs in test files, not source files. It was already correctly defined intests/integration/vertica/test_vertica.py, making the entry in the source file both redundant and harmful.📊 Impact Assessment
metadata-ingestion— Vertica source plugin only🔗 References