Skip to content

feat(ingest/powerbi): support 'Sql.Databases' M-Query data access function#16616

Merged
ligfx merged 2 commits into
masterfrom
mm--powerbi-sql-databases-plural
Mar 24, 2026
Merged

feat(ingest/powerbi): support 'Sql.Databases' M-Query data access function#16616
ligfx merged 2 commits into
masterfrom
mm--powerbi-sql-databases-plural

Conversation

@ligfx
Copy link
Copy Markdown
Contributor

@ligfx ligfx commented Mar 16, 2026

No description provided.

@github-actions github-actions Bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Linear: ING-1944

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ngestion/source/powerbi/m_query/pattern_handler.py 85.71% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Mar 16, 2026

🔴 Meticulous spotted visual differences in 6 of 1433 screens tested: view and approve differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit 83c5dcb. This comment will update as new commits are pushed.

@rajatoss
Copy link
Copy Markdown
Member

rajatoss commented Mar 16, 2026

Connector Tests Results

All connector tests passed for commit 4965926

View full test logs →

To skip connector tests, add the skip-connector-tests label (org members only).

Autogenerated by the connector-tests CI pipeline.

@ligfx ligfx force-pushed the mm--powerbi-sql-databases-plural branch from 771d2ba to c8c6990 Compare March 16, 2026 23:34
@maggiehays maggiehays added the pending-submitter-response Issue/request has been reviewed but requires a response from the submitter label Mar 17, 2026
@ligfx ligfx changed the base branch from master to mm--powerbi-cleanup-mcp-workunits March 18, 2026 19:53
@ligfx ligfx force-pushed the mm--powerbi-sql-databases-plural branch from c8c6990 to bd6cb33 Compare March 18, 2026 19:53
@maggiehays maggiehays added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Mar 18, 2026
@ligfx ligfx force-pushed the mm--powerbi-sql-databases-plural branch from bd6cb33 to a68bf8b Compare March 18, 2026 21:24
@ligfx ligfx force-pushed the mm--powerbi-cleanup-mcp-workunits branch from 73f8666 to 78b3a23 Compare March 19, 2026 00:23
@ligfx ligfx force-pushed the mm--powerbi-sql-databases-plural branch from a68bf8b to 87e3623 Compare March 19, 2026 00:23
Comment thread metadata-ingestion/tests/integration/powerbi/test_m_parser.py Outdated
Copy link
Copy Markdown
Contributor

@askumar27 askumar27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left minor comments.

@github-actions
Copy link
Copy Markdown
Contributor

Your PR has been assigned to anush.kumar for review (ING-1944).

@ligfx ligfx force-pushed the mm--powerbi-sql-databases-plural branch from d23600e to 4965926 Compare March 24, 2026 22:08
@ligfx ligfx merged commit 1dd44ce into master Mar 24, 2026
60 of 100 checks passed
@ligfx ligfx deleted the mm--powerbi-sql-databases-plural branch March 24, 2026 23:21
david-leifker pushed a commit that referenced this pull request May 27, 2026
- docs(free trials): updating free trial links (#16758)
- docs(readme): Add link for Free Cloud Trial on Readme (#16753)
- fix(vertica): remove accidental pytest import from source file (#16763)
- docs(readme): Remove Roadmap link from README (#16765)
- chore(tests/mssql): update formatting of golden files (#16735)
- feat(ingest/powerbi): support 'Sql.Databases' M-Query data access function (#16616)
- fix(ingest/mssql): lowercase field paths when convert_urns_to_lowercase=True (#16736)
- feat(cli): add `datahub init --sso` for browser-based SSO login (#16715)
- feat(cli): add --context / -C flag for passing context in event properties (#16764)
- build(ingest): bump python-liquid from <2 to >=2.0.0,<3.0.0 (#16697)
- chore(docs): Update docs for summary pages, multiple data products, and ingestion (#16584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants