Port kurtosis_pop UDAF#7
Merged
dmitriibugakov merged 3 commits intodatafusion-contrib:mainfrom Sep 27, 2024
Merged
Conversation
Collaborator
dmitriibugakov
left a comment
dmitriibugakov
left a comment
There was a problem hiding this comment.
Thank you @dharanad
alamb
reviewed
Sep 27, 2024
|
|
||
| #[tokio::test] | ||
| async fn test_kurtosis_pop() { | ||
| let mut execution = TestExecution::new().await.unwrap().with_setup(TEST_TABLE).await; |
Contributor
There was a problem hiding this comment.
There were additional tests too in apache/datafusion#12647
Maybe it is time to consider adding sqllogictest to this repo too 🤔 (not as part of this PR)
Contributor
Author
There was a problem hiding this comment.
+1 I was thinking the same. Plus it kind of hazzle to assert those table output snapshots.
Contributor
alamb
approved these changes
Sep 27, 2024
Collaborator
|
lgtm |
Contributor
Author
|
Thank You @alamb & @dmitrybugakov for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of apache/datafusion#12625
Porting
kurtosis_poporginally authored by @goldmedal