Repository navigation
Fix View.verifyConfig mutating caller-shared bigquery configs - #2273
Merged
Merged
Conversation
Shallow-clone unverifiedConfig.bigquery before the hoist-then-delete loop so a shared `bigquery` object is not stripped across successive publish() calls. View.verifyConfig has its own hoist-then-delete loop outside LegacyConfigConverter; #2260 fixed the converter, which covers Table and IncrementalTable but not View. Fixes #2267.
apilaskowski
approved these changes
Sep 3, 2026
rafal-hawrylak
added a commit
that referenced
this pull request
Sep 7, 2026
Bumps the npm package version to release two shared-config mutation fixes (#2273 View.verifyConfig, #2283 Session.declare — both stop in-place hoists/deletes from stripping fields off a caller-held config) alongside the PropertyGraph improvements from #2275 (tags support) and #2281 (preserve explicit includeDependentAssertions=false).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shallow-clone unverifiedConfig.bigquery before the hoist-then-delete loop so a shared
bigqueryobject is not stripped across successive publish() calls. View.verifyConfig has its own hoist-then-delete loop outside LegacyConfigConverter; #2260 fixed the converter, which covers Table and IncrementalTable but not View.Fixes #2267.