Increase numberOfTestsPerMethod to 100 for testDeterministicAndNonDeterministicProvidersReturnValues#745
Conversation
…erministicProvidersReturnValues
PR Summary
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #745 +/- ##
============================================
+ Coverage 92.84% 92.85% +0.01%
+ Complexity 2592 2591 -1
============================================
Files 281 281
Lines 5126 5126
Branches 530 530
============================================
+ Hits 4759 4760 +1
+ Misses 240 238 -2
- Partials 127 128 +1 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kingthorin
left a comment
There was a problem hiding this comment.
Logically this should be fine, but technically we could end-up with situations where low choice sets (sex, boolean, etc) do generate the same value 100 times. (Improbable but not impossible.) In such cases the failing GitHub action/workflow could just be re-run from the WebUI.
|
yes, should be very rare case. |
…erministicProvidersReturnValues (datafaker-net#745)
…erministicProvidersReturnValues (datafaker-net#745)
…erministicProvidersReturnValues (#745)
It looks like 10 is not enough for some cases e.g. https://github.com/datafaker-net/datafaker/actions/runs/4554807351/jobs/8033243612
Also there is no need to continue invocations in case set's size is >= 2