Repository navigation
Follow-up to #1932: restore NYSE class shares, drop ETFs, check whole stock lists - #1944
Merged
Merged
Conversation
… stock lists * restore 22 NYSE class shares still listed as common stock (BRK.A, BRK.B, BF.A, BF.B, ...) * remove ETFs HF and TPZ from symbol_nyse * trim padded entries in symbol_nsdq (BLIN, ENZY, IMNP, TORM) * AbstractProviderListTest: validate every list entry against the TestSpec regex * StockTest: per-list regexes in providerListTest(), no-duplicates check, drop redundant repeated tests * document data source of nyseSymbol() and add a release note Co-Authored-By: Claude Opus 5.5 <[email protected]>
PR Summary
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1944 +/- ##
============================================
+ Coverage 92.41% 92.42% +0.01%
Complexity 3570 3570
============================================
Files 348 348
Lines 7065 7065
Branches 691 691
============================================
+ Hits 6529 6530 +1
+ Misses 371 370 -1
Partials 165 165 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks, nice work!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1932. It applies the review comments left on that PR.
Data (
stock.yml)otherlisted.txt(Exchange=N, ETF=N, snapshot 2026-10-23):AGM.A AKO.A AKO.B BF.A BF.B BIO.B BRK.A BRK.B CIG.C CRD.A CRD.B GEF.B GTN.A HEI.A HVT.A LEN.B MKC.V MOG.A MOG.B PBR.A TAP.A WSO.B. Each one is placed back at its original position.symbol_nyse:HF,TPZ.symbol_nsdq:BLIN,ENZY,IMNP,TORMhad trailing spaces (the same bug as Does "symbol_nyse" in stock.yml contain valid values? #1928).symbol_nysenow has 1429 entries.Tests
AbstractProviderListTest.testProviderListnow checks every list entry against theTestSpecregex, not only the sampled value. This applies to all providers that pass a regex; the full suite passes.StockTest: eachsymbol_*list andexchangesgets a strict regex inproviderListTest(). NYSE uses[A-Z]{1,4}(\.[A-Z])?, which acceptsBRK.Band still rejects^,/,$and.WS. A parameterized no-duplicates check was added, and the redundant@RepeatedTestmethods were removed.Docs
Stock.nyseSymbol()names the data source and snapshot date. Spotless strips comments from YAML, so the note can't live instock.yml.docs/releases/3.0.0-SNAPSHOT.mdabout the smaller NYSE list, which changes seeded output and makesunique()run out sooner.🤖 Generated with Claude Code