Skip to content

Add new device models to device.yml#1750

Merged
kingthorin merged 4 commits intodatafaker-net:mainfrom
yuokada:patch-2
Jan 21, 2026
Merged

Add new device models to device.yml#1750
kingthorin merged 4 commits intodatafaker-net:mainfrom
yuokada:patch-2

Conversation

@yuokada
Copy link
Copy Markdown
Contributor

@yuokada yuokada commented Jan 20, 2026

This pull request updates the device.yml file to expand the list of supported devices with many recent models from major smartphone brands. The additions ensure broader and more up-to-date device coverage, which is important for features or tests that rely on this device list.

Device list updates:

  • Added iPhone 15 and iPhone 16 series devices, including Plus, Pro, and Pro Max variants.
  • Added OnePlus models from OnePlus 7 through OnePlus 12, including Pro and T variants.
  • Added Samsung Galaxy S10 through S24 series, including Plus, Ultra, and e variants.
  • Added Google Pixel 7a, 8, 8 Pro, 8a, 9, 9 Pro, and 9 Pro XL.
  • Added several Xiaomi Mi and Redmi Note series devices, including Mi 9, 10, 11, 12, 13, 14, and Redmi Note 7–12.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Jan 20, 2026

PR Summary

  • Added support for latest iPhone models
    This update adds new iPhone models to the list of devices, including "iPhone 15", "iPhone 15 Plus", "iPhone 15 Pro", "iPhone 15 Pro Max", "iPhone 16", "iPhone 16 Plus", "iPhone 16 Pro", and "iPhone 16 Pro Max".

  • Extended device list with new OnePlus models
    Several new OnePlus models have been added to the records. This includes the "OnePlus 7" series, "OnePlus 8" series, as well as the "OnePlus 9 Pro", "OnePlus 10 Pro", "OnePlus 11", and "OnePlus 12".

  • Included numerous Samsung Galaxy models
    The update brings an extensive list of Samsung Galaxy models ranging from "Galaxy S10" to "Galaxy S24 Ultra". This addition will allow for better coverage of Samsung devices.

  • Updated records with new Google Pixel models
    The PR also adds new Google Pixel models like the "Google Pixel 7a", "Google Pixel 8" series, and "Google Pixel 9" series.

  • Introduced multiple new Xiaomi models
    This update incorporates various Xiaomi models, including the "Xiaomi Mi 9", "Xiaomi Mi 10", "Xiaomi Mi 11", "Xiaomi 12", "Xiaomi 13", "Xiaomi 14", and the new Xiaomi Redmi Note series (from 7 to 12).

  • Improved structure in the "platform" section
    For better readability and organization, the indentation within the "platform" section has been adjusted. This structural improvement will make navigation easier.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 20, 2026 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.33%. Comparing base (210089e) to head (272d2df).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1750      +/-   ##
============================================
- Coverage     92.35%   92.33%   -0.02%     
  Complexity     3440     3440              
============================================
  Files           338      338              
  Lines          6785     6785              
  Branches        670      670              
============================================
- Hits           6266     6265       -1     
- Misses          354      355       +1     
  Partials        165      165

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kingthorin
Add Apple iPhone 17 generation
4371a2f 
There is no Plus model in the 17 line-up, but Apple did add the Air.

Signed-off-by: kingthorin <[email protected]>
@kingthorin kingthorin requested a review from Copilot January 20, 2026 16:45
Copilot AI reviewed Jan 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request expands the device.yml file with many recent smartphone models from major manufacturers to improve device coverage for testing or feature functionality that depends on this list.

Changes:

  • Added iPhone 15 and 16 series models (Plus, Pro, Pro Max variants)
  • Added OnePlus 7-12 series devices including Pro and T variants
  • Added Samsung Galaxy S10-S24 series with Plus, Ultra, and e variants
  • Added Google Pixel 7a through 9 Pro XL models
  • Added Xiaomi Mi 9-14 and Redmi Note 7-12 devices
  • Included unreleased devices: iPhone 17 series and iPhone Air

@kingthorin
Copy link
Copy Markdown
Collaborator

kingthorin commented Jan 20, 2026

Apparently that was beyond copilot's knowledge window. For the record the Apple iPhone 17 series were released Sept 2025.

@kingthorin
Copy link
Copy Markdown
Collaborator

kingthorin commented Jan 20, 2026

I'm going to let someone else merge this. Since I ended up contributing to it someone else should also review it.

snuyanzin
snuyanzin reviewed Jan 20, 2026
View reviewed changes
snuyanzin
snuyanzin reviewed Jan 20, 2026
View reviewed changes
snuyanzin
snuyanzin reviewed Jan 20, 2026
View reviewed changes
snuyanzin
snuyanzin reviewed Jan 20, 2026
View reviewed changes
src/main/resources/en/device.yml Outdated
Comment on lines +98 to +100
- "Samsung Galaxy S24"
- "Samsung Galaxy S24 Plus"
- "Samsung Galaxy S24 Ultra"
Copy link
Copy Markdown
Collaborator

@snuyanzin snuyanzin Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already S25
https://www.samsung.com/smartphones/all-smartphones/

@kingthorin
Copy link
Copy Markdown
Collaborator

kingthorin commented Jan 20, 2026 •
edited
Loading

Thanks @snuyanzin I'll tackle that later this evening tomorrow.

@yuokada
Copy link
Copy Markdown
Contributor Author

yuokada commented Jan 21, 2026

I've added the devices pointed at the review comments.

@asolntsev asolntsev added this to the 2.6.0 milestone Jan 21, 2026
@asolntsev asolntsev added the enhancement New feature or request label Jan 21, 2026
@kingthorin kingthorin merged commit 0bb9bc1 into datafaker-net:main Jan 21, 2026
13 checks passed
@yuokada yuokada deleted the patch-2 branch January 21, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snuyanzin snuyanzin snuyanzin left review comments

Copilot code review Copilot Copilot left review comments

@asolntsev asolntsev asolntsev approved these changes

@kingthorin kingthorin kingthorin approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

2.5.4

Development

Successfully merging this pull request may close these issues.

6 participants

@yuokada @codecov-commenter @kingthorin @asolntsev @snuyanzin