Skip to content

Add Bluey provider with characters, quotes and locations#1740

Merged
kingthorin merged 4 commits intodatafaker-net:mainfrom
ferclager:chore/add-bluey-provider
Dec 31, 2025
Merged

Add Bluey provider with characters, quotes and locations#1740
kingthorin merged 4 commits intodatafaker-net:mainfrom
ferclager:chore/add-bluey-provider

Conversation

@ferclager
Copy link
Copy Markdown
Contributor

@ferclager ferclager commented Dec 29, 2025

No description provided.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Dec 29, 2025

PR Summary

  • New Entertainment Provider Added
    A new class named Bluey has been added to the entertainment package. This addition allows us to handle and organize new types of entertainment content more effectively.

  • Methods for New Content Retrieval
    New methods have been created in the Bluey class. These methods are designed to retrieve character information, specific locations, and memorable quotes.

  • Updates to EntertainmentProviders Interface
    The EntertainmentProviders interface has been updated. It now includes a method specifically for the new Bluey provider, ensuring it integrates smoothly with the rest of the application.

  • New Database File Created
    A new resource file, bluey.yml, has been created. It holds sample data including character info, locations, and quotes. This will serve as a vital resource for testing and future development.

  • Test Class for the New Provider
    To ensure that the functionality of the new Bluey provider is working as expected, we've created a new test class BlueyTest. This ensures the quality of our code and the reliability of the new feature.

@kingthorin
Copy link
Copy Markdown
Collaborator

kingthorin commented Dec 29, 2025

Build is failing, likely needs a ./mvnw spotless:apply so that the yaml is properly formatted.

@kingthorin kingthorin requested a review from Copilot December 29, 2025 13:39
Copilot AI reviewed Dec 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new Bluey provider to the DataFaker library, enabling generation of fake data related to the Bluey animated television series. The implementation follows the established pattern for entertainment providers.

Key Changes

  • New Bluey provider class with methods to generate character names, locations, and quotes
  • YAML data file containing Bluey-related data (9 characters, 4 locations, 5 quotes)
  • Test class following the standard entertainment provider test pattern

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/main/java/net/datafaker/providers/entertainment/Bluey.java New provider class with character(), location(), and quote() methods
src/main/resources/en/bluey.yml Data file containing characters, locations, and quotes from the Bluey series
src/test/java/net/datafaker/providers/entertainment/BlueyTest.java Test class validating the provider methods against YAML keys
src/main/java/net/datafaker/providers/entertainment/EntertainmentProviders.java Registration of the Bluey provider in the entertainment providers interface

kingthorin
kingthorin reviewed Dec 29, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line added in EnFile is missing a trailing comma

@ferclager
Copy link
Copy Markdown
Contributor Author

ferclager commented Dec 29, 2025

Oops... you are right... I missed.
Now updated

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 29, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.32%. Comparing base (04b7adf) to head (a06b322).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1740      +/-   ##
============================================
- Coverage     92.40%   92.32%   -0.09%     
- Complexity     3437     3439       +2     
============================================
  Files           337      338       +1     
  Lines          6779     6785       +6     
  Branches        670      670              
============================================
  Hits           6264     6264              
- Misses          352      355       +3     
- Partials        163      166       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ferclager
Copy link
Copy Markdown
Contributor Author

ferclager commented Dec 31, 2025

Hi!!!
Do I need to do anything else in my PR?

@kingthorin
Update Bluey.java
a06b322 
Co-authored-by: Copilot <[email protected]>
@kingthorin
Copy link
Copy Markdown
Collaborator

kingthorin commented Dec 31, 2025

I just did it. Assuming the build passes I'll merge it later today.

@kingthorin kingthorin merged commit e128521 into datafaker-net:main Dec 31, 2025
13 checks passed
@asolntsev asolntsev added this to the 2.6.0 milestone Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@kingthorin kingthorin kingthorin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@ferclager @kingthorin @codecov-commenter @asolntsev