Skip to content

#1708 fix test failing because some product might have space in name#1711

Merged
asolntsev merged 1 commit intomainfrom
fix/1708-commerce-test
Oct 28, 2025
Merged

#1708 fix test failing because some product might have space in name#1711
asolntsev merged 1 commit intomainfrom
fix/1708-commerce-test

Conversation

@asolntsev
Copy link
Copy Markdown
Collaborator

@asolntsev asolntsev commented Oct 28, 2025

Alternative fix for #1708

@vicky-iv

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Oct 28, 2025

PR Summary

  • Updating CommerceTest.java:
    The current update improved our product validation tests. It includes the addition of a test method that checks if the product names are constructed as anticipated - with specific adjectives, material, and product types.

  • Modifying test.yml:
    In line with the testing update, our configuration file, test.yml, has been altered to include specific listings in a new 'commerce' section. This gives us more control over the test cases involving adjectives, material, and product, making our tests more comprehensive and robust.

@asolntsev asolntsev force-pushed the fix/1708-commerce-test branch from cfa8ea3 to 997bdbf Compare October 28, 2025 07:11
@asolntsev asolntsev requested a review from kingthorin October 28, 2025 07:12
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.31%. Comparing base (60d2f95) to head (997bdbf).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1711      +/-   ##
============================================
+ Coverage     92.28%   92.31%   +0.02%     
- Complexity     3433     3435       +2     
============================================
  Files           337      337              
  Lines          6779     6779              
  Branches        670      670              
============================================
+ Hits           6256     6258       +2     
  Misses          356      356              
+ Partials        167      165       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asolntsev asolntsev added enhancement New feature or request proposal labels Oct 28, 2025
@asolntsev asolntsev self-assigned this Oct 28, 2025
Copy link
Copy Markdown
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this does what we need. Thanks!

@asolntsev asolntsev added this to the 2.6.0 milestone Oct 28, 2025
@asolntsev asolntsev merged commit 8466d52 into main Oct 28, 2025
13 checks passed
@asolntsev asolntsev deleted the fix/1708-commerce-test branch October 28, 2025 12:31
@vicky-iv
Copy link
Copy Markdown
Contributor

@asolntsev That looks much better than my bulky attempt - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request proposal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants