Skip to content

Corrected typos in ko.yml#1645

Merged
kingthorin merged 3 commits intodatafaker-net:mainfrom
momoysm:fix/ko-typo
Sep 8, 2025
Merged

Corrected typos in ko.yml#1645
kingthorin merged 3 commits intodatafaker-net:mainfrom
momoysm:fix/ko-typo

Conversation

@momoysm
Copy link
Copy Markdown
Contributor

@momoysm momoysm commented Sep 7, 2025

Simple typos and spacing corrections to conform to standard Korean.

Copy link
Copy Markdown
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asolntsev asolntsev added this to the 2.4.5 milestone Sep 7, 2025
@momoysm
Copy link
Copy Markdown
Contributor Author

momoysm commented Sep 7, 2025

I think the test code failed, so can I revise it and upload it again?

@kingthorin
Copy link
Copy Markdown
Collaborator

kingthorin commented Sep 7, 2025

12:46:47.752 [ERROR] NoDuplicatesInYmlTest.noDuplicatesInArrays:32 Duplicates in file src/main/resources/ko.yml: {/ko/faker/kpop/solo=[서현, 조미, 니콜, 윤미래]}

You can just commit a fix and push it to the same branch the PR is using.

@momoysm
Copy link
Copy Markdown
Contributor Author

momoysm commented Sep 7, 2025

Thanks for the advice, I'll revise it and upload it again by tomorrow

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (29ebc3c) to head (3224167).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1645      +/-   ##
============================================
- Coverage     92.41%   92.38%   -0.03%     
+ Complexity     3383     3382       -1     
============================================
  Files           333      333              
  Lines          6681     6681              
  Branches        664      664              
============================================
- Hits           6174     6172       -2     
- Misses          348      349       +1     
- Partials        159      160       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kingthorin kingthorin merged commit 3030f0f into datafaker-net:main Sep 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants