Update CreditCard formats in Finance provider#1637
Merged
asolntsev merged 6 commits intodatafaker-net:mainfrom Sep 4, 2025
Merged
Update CreditCard formats in Finance provider#1637asolntsev merged 6 commits intodatafaker-net:mainfrom
asolntsev merged 6 commits intodatafaker-net:mainfrom
Conversation
They've been dead for 8 years (as per https://web.archive.org/web/20100808000653/http://www.maestrocard.com/uk/about/switch_to_maestro.html) Ooops
They were removed in 2011 according to https://en.wikipedia.org/wiki/Solo_(debit_card)
asolntsev
approved these changes
Sep 4, 2025
Collaborator
|
@Fishbowler Thank you for the PR, looks good! 19:42:04.733 [ERROR] FinanceTest.unionpayCard:104
Expecting actual:
"6441241451881464"
to start with:
"62" |
asolntsev
reviewed
Sep 4, 2025
asolntsev
approved these changes
Sep 4, 2025
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1637 +/- ##
============================================
- Coverage 92.41% 92.41% -0.01%
Complexity 3383 3383
============================================
Files 333 333
Lines 6670 6668 -2
Branches 664 664
============================================
- Hits 6164 6162 -2
Misses 348 348
Partials 158 158 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks! |
Contributor
Author
|
The invalid Mastercard range is causing me some grief in a project. Any chance that v2.4.5 is imminent? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix random data generation of credit cards
I've put the citation of sources in the commits for anyone who's interested.