#1617 avoid useless NoSuchMethodRuntimeException in logs#1620
Merged
Conversation
PR Summary
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1620 +/- ##
============================================
- Coverage 92.41% 92.33% -0.08%
+ Complexity 3357 3354 -3
============================================
Files 331 331
Lines 6618 6618
Branches 655 655
============================================
- Hits 6116 6111 -5
- Misses 346 348 +2
- Partials 156 159 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
LGTM, feel free to merge this. Thanks for fixing this so quickly! |
Collaborator
Author
|
Seems we should release 2.4.5 soon? |
Contributor
I'm happy if we release a new version. You should be able to make the release, so if you want to, feel free, I have no issue with that, but perhaps we can get those 2 open PRs in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.