Skip to content

add Severance characters#1552

Merged
kingthorin merged 1 commit intomainfrom
feature/severance
May 10, 2025
Merged

add Severance characters#1552
kingthorin merged 1 commit intomainfrom
feature/severance

Conversation

@asolntsev
Copy link
Copy Markdown
Collaborator

No description provided.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented May 10, 2025

PR Summary

  • Added 'Severance' to the list of entertainment providers
    We have updated README.md to include 'Severance' among the recognized entertainment providers in our project.

  • Comprehensive description of the 'Severance' provider
    The 'Severance' provider has been documented in the providers.md, providing essential details and a link for further reference.

  • Introduction of a new 'Severance' class
    We created a new class that specifically deals with data from the 'Severance' entertainment provider. This class is designed to return character names from the series.

  • Interface updates for 'Severance' support
    The EntertainmentProviders interface has been updated and now includes a method for retrieving data from the newly added 'Severance' provider.

  • Creation of a YAML file for 'Severance'
    A severance.yml file has been made containing all the necessary entries related to the 'Severance' provider.

  • Reference update in EnFile.java
    The EnFile.java has been modified to refer to the newly created severance.yml file for data retrieval purposes.

  • Enhanced reachability-metadata.json
    The metadata file has been updated to include information on the methods and classes associated with 'Severance' provider.

  • Functionality check through SeveranceTest.java
    For ensuring the effectiveness of the newly added 'Severance' provider, a test class, SeveranceTest.java, has been added. This class conducts appropriate tests to verify the functionality of the new feature.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.44%. Comparing base (fc64cf1) to head (9f86504).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1552      +/-   ##
============================================
+ Coverage     92.37%   92.44%   +0.06%     
- Complexity     3288     3293       +5     
============================================
  Files           327      328       +1     
  Lines          6478     6482       +4     
  Branches        630      630              
============================================
+ Hits           5984     5992       +8     
+ Misses          339      337       -2     
+ Partials        155      153       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asolntsev asolntsev added this to the 2.4.4 milestone May 10, 2025
@asolntsev asolntsev force-pushed the feature/severance branch from 4a7570b to 8de0ff9 Compare May 10, 2025 13:04
@asolntsev asolntsev requested review from bodiam and kingthorin May 10, 2025 13:04
@Override
protected Collection<TestSpec> providerListTest() {
return List.of(
TestSpec.of(futurama::character, "severance.characters")
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm that shouldn't have passed

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it's because of the mixed declaration.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, copy-paste error :)

Comment on lines +10 to +15
private final Severance futurama = getFaker().severance();

@Override
protected Collection<TestSpec> providerListTest() {
return List.of(
TestSpec.of(futurama::character, "severance.characters")
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private final Severance futurama = getFaker().severance();
@Override
protected Collection<TestSpec> providerListTest() {
return List.of(
TestSpec.of(futurama::character, "severance.characters")
private final Severance severance = getFaker().severance();
@Override
protected Collection<TestSpec> providerListTest() {
return List.of(
TestSpec.of(severance::character, "severance.characters")

@asolntsev asolntsev force-pushed the feature/severance branch from 8de0ff9 to 9f86504 Compare May 10, 2025 16:03
@asolntsev asolntsev requested a review from kingthorin May 10, 2025 16:03
@kingthorin kingthorin merged commit 1bc0699 into main May 10, 2025
13 checks passed
@kingthorin kingthorin deleted the feature/severance branch May 10, 2025 16:07
@kingthorin
Copy link
Copy Markdown
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants