Skip to content

Do not use deprecated DateAndTime#1544

Merged
kingthorin merged 1 commit intodatafaker-net:mainfrom
snuyanzin:timeanddate
Apr 12, 2025
Merged

Do not use deprecated DateAndTime#1544
kingthorin merged 1 commit intodatafaker-net:mainfrom
snuyanzin:timeanddate

Conversation

@snuyanzin
Copy link
Copy Markdown
Collaborator

No description provided.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Apr 12, 2025

PR Summary

  • Enhanced Precision in 'Business' class
    • Improved the way we calculate the expiry date of a credit card by using a more accurate method called 'LocalDate', and organized the way this date is represented using 'DateTimeFormatter'.
  • Optimized 'JavaObjectTransformerTest' class
    • Refactored the component handling birth dates to use 'LocalDate' instead of 'Date' for better date management.
    • Standardized the method to generate dates in certain operations, opting for 'faker.timeAndDate().birthday()', which brings more consistency in date generation.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.40%. Comparing base (f3ee0de) to head (f7d3698).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1544      +/-   ##
============================================
- Coverage     92.43%   92.40%   -0.03%     
+ Complexity     3275     3274       -1     
============================================
  Files           325      325              
  Lines          6441     6442       +1     
  Branches        625      625              
============================================
- Hits           5954     5953       -1     
  Misses          336      336              
- Partials        151      153       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asolntsev asolntsev added this to the 2.4.4 milestone Apr 12, 2025
@kingthorin kingthorin merged commit 3886e44 into datafaker-net:main Apr 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants