Skip to content

Made IBANs uppercase only.#1529

Merged
kingthorin merged 1 commit intomainfrom
iban
Apr 6, 2025
Merged

Made IBANs uppercase only.#1529
kingthorin merged 1 commit intomainfrom
iban

Conversation

@bodiam
Copy link
Copy Markdown
Contributor

@bodiam bodiam commented Apr 6, 2025

IBANs, while technically capable of being lowercase, should normally be uppercase.

Technically, IBANs (International Bank Account Numbers) are case-insensitive, meaning they can be written in lowercase or uppercase without affecting their validity. However, the official format uses uppercase letters, and most systems expect IBANs in uppercase for consistency, readability, and to avoid confusion (especially with similar-looking characters like l and 1, or o and 0).

So:
option1: ✅ DE44500105175407324931 (preferred)
option2: ✅ de44500105175407324931 (still valid, but not standard)
option3: ❌ De44500105175407324931 (mixed case is unusual and may be rejected by some systems)

We use option 1.

Motivation for change: https://youtu.be/S6Z7vB5zc0g?t=813

…lowercase, should normally be uppercase.

Technically, IBANs (International Bank Account Numbers) are case-insensitive, meaning they can be written in lowercase or uppercase without affecting their validity.
However, the official format uses uppercase letters, and most systems expect IBANs in uppercase for consistency, readability, and to avoid confusion (especially with similar-looking characters like l and 1, or o and 0).

So:
    option1: ✅ DE44500105175407324931 (preferred)
    option2: ✅ de44500105175407324931 (still valid, but not standard)
    option3: ❌ De44500105175407324931 (mixed case is unusual and may be rejected by some systems)

 We use option 1.
@bodiam bodiam changed the title Made IBANs uppercase only. IBANs, while technically capable of being … Made IBANs uppercase only. Apr 6, 2025
@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Apr 6, 2025

PR Summary

  • Updated IBAN Format
    The rules for creating International Bank Account Numbers (IBAN) in our finance system have been revised. Earlier, both uppercase and lowercase letters were allowed, but now only uppercase letters can be used. This update enhances the consistency and readability of our bank account numbers.

  • Modified Test Case for IBAN Generation
    The unit test for generating International Bank Account Numbers has been tweaked to match the updated format. This change ensures that we are consistently producing and checking these numbers according to the new rule, improving our system's reliability.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (77c2886) to head (0070014).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1529      +/-   ##
============================================
- Coverage     92.53%   92.48%   -0.05%     
+ Complexity     3277     3275       -2     
============================================
  Files           325      325              
  Lines          6440     6440              
  Branches        625      625              
============================================
- Hits           5959     5956       -3     
- Misses          333      335       +2     
- Partials        148      149       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asolntsev asolntsev added this to the 2.4.3 milestone Apr 6, 2025
@kingthorin kingthorin merged commit 00e7efa into main Apr 6, 2025
13 checks passed
@kingthorin kingthorin deleted the iban branch April 6, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants