Skip to content

Use jdk 24 in ci#1521

Merged
kingthorin merged 2 commits intodatafaker-net:mainfrom
snuyanzin:24
Mar 24, 2025
Merged

Use jdk 24 in ci#1521
kingthorin merged 2 commits intodatafaker-net:mainfrom
snuyanzin:24

Conversation

@snuyanzin
Copy link
Copy Markdown
Collaborator

@snuyanzin snuyanzin commented Mar 24, 2025 •
edited
Loading

Seems need to wait for

  1. fix from JaCoCo (with support of jdk24)
  2. jdk24 version for arm

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Mar 24, 2025

PR Summary

  • Java Version Update in Build Workflow
    The version of Java used in the building process of our project has been updated from 23 to 24. This essentially ensures our code is compatible with the latest technology updates and stability improvements.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (6d00f0a) to head (95d7790).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1521      +/-   ##
============================================
+ Coverage     92.42%   92.48%   +0.06%     
- Complexity     3272     3274       +2     
============================================
  Files           325      325              
  Lines          6439     6439              
  Branches        625      625              
============================================
+ Hits           5951     5955       +4     
+ Misses          336      334       -2     
+ Partials        152      150       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kingthorin
Copy link
Copy Markdown
Collaborator

kingthorin commented Mar 24, 2025 •
edited
Loading

Temurin doesn't have 24 for arm yet:
image
https://adoptium.net/temurin/releases/?variant=openjdk11&jvmVariant=hotspot&version=24&arch=arm

Edit: Hmm that might be misleading, the page also says there isn't an arm 23 which obviously there was since build wasn't previously failing.

@snuyanzin
Copy link
Copy Markdown
Collaborator Author

snuyanzin commented Mar 24, 2025

yep
based on logs there lots of

 java.lang.instrument.IllegalClassFormatException: Error while instrumenting java/sql/Timestamp with JaCoCo 0.8.12.202403310830/dbfb6f2.
	at org.jacoco.agent.rt.internal_aeaf9ab.CoverageTransformer.transform(CoverageTransformer.java:94)
	at java.instrument/java.lang.instrument.ClassFileTransformer.transform(ClassFileTransformer.java:257)
	at java.instrument/sun.instrument.TransformerManager.transform(TransformerManager.java:188)
	at java.instrument/sun.instrument.InstrumentationImpl.transform(InstrumentationImpl.java:594)
	at java.base/java.lang.ClassLoader.defineClass2(Native Method)
	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1052)
	at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:164)
	at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:735)
	at java.base/jdk.internal.loader.BuiltinClassLoader.findClassInModuleOrNull(BuiltinClassLoader.java:678)
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:604)
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:639)
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:608)

seems need for newer JaCoCo version with jdk24 support which is not released yet...

@kingthorin
Copy link
Copy Markdown
Collaborator

kingthorin commented Mar 24, 2025

JaCoCo Java 23 support is less than a month old:
image

@kingthorin
Copy link
Copy Markdown
Collaborator

kingthorin commented Mar 24, 2025

Hmmmm may have been a build cache issue?

@snuyanzin
Copy link
Copy Markdown
Collaborator Author

snuyanzin commented Mar 24, 2025 •
edited
Loading

well, they have jdk23 experimental support with 0.8.12 which is in our pom
probably for our project it is enough
https://github.com/jacoco/jacoco/releases/tag/v0.8.12

@kingthorin
Copy link
Copy Markdown
Collaborator

kingthorin commented Mar 24, 2025

Everything is passing after updating the PR branch.

@snuyanzin
Copy link
Copy Markdown
Collaborator Author

snuyanzin commented Mar 24, 2025

interesting...
then may be indeed some caching issue..
thanks for noticing

@kingthorin kingthorin merged commit 587b5de into datafaker-net:main Mar 24, 2025
13 checks passed
@kingthorin
Copy link
Copy Markdown
Collaborator

kingthorin commented Mar 24, 2025

Looks good:
image

@asolntsev asolntsev added this to the 2.4.3 milestone Mar 24, 2025
@asolntsev asolntsev added the java Pull requests that update Java code label Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kingthorin kingthorin kingthorin approved these changes

Assignees

No one assigned

Labels

java Pull requests that update Java code

Projects

None yet

Milestone

2.4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@snuyanzin @codecov-commenter @kingthorin @asolntsev