Skip to content

Use allowZeroInvocations junit feature instead of a WA#1520

Merged
kingthorin merged 2 commits intodatafaker-net:mainfrom
snuyanzin:wa
Mar 24, 2025
Merged

Use allowZeroInvocations junit feature instead of a WA#1520
kingthorin merged 2 commits intodatafaker-net:mainfrom
snuyanzin:wa

Conversation

@snuyanzin
Copy link
Copy Markdown
Collaborator

@snuyanzin snuyanzin commented Mar 24, 2025 •
edited by kingthorin
Loading

At some point of time there was introduced a work around for the case when parameterized test input is empty.
Since junit 5.12.x there is a special annotation flag for that, so just replacing old workaround with this flag usage.

Edit: Original intro was here: #677

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Mar 24, 2025

PR Summary

  • Update of testing method parameters
    The testProviderList method has seen an update to its testing parameters to allow tests to run even without any invocations.

  • Enhancement of testing annotation
    The testNoDuplications method now has enhanced testing annotations, meaning we are now allowing tests to run with no invocations.

  • Modification of returned data
    The providerListTest method has been altered and it now returns an empty set of data as opposed to a dummy test object, simplifying checks and reducing unnecessary operations.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (994f99c) to head (83449e9).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1520      +/-   ##
============================================
+ Coverage     92.42%   92.52%   +0.10%     
- Complexity     3271     3275       +4     
============================================
  Files           325      325              
  Lines          6439     6439              
  Branches        625      625              
============================================
+ Hits           5951     5958       +7     
+ Misses          335      332       -3     
+ Partials        153      149       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kingthorin
kingthorin approved these changes Mar 24, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kingthorin kingthorin merged commit 6d00f0a into datafaker-net:main Mar 24, 2025
13 checks passed
@asolntsev asolntsev added this to the 2.4.3 milestone Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kingthorin kingthorin kingthorin approved these changes

Assignees

No one assigned

Labels

refactoring

Projects

None yet

Milestone

2.4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@snuyanzin @codecov-commenter @kingthorin @asolntsev