Skip to content

Adjust malefirstName to align with its female counterpart, and java naming conventions - maleFirstName#1519

Merged
kingthorin merged 2 commits intodatafaker-net:mainfrom
apollo-de:fix/datafaker-1518
Mar 24, 2025
Merged

Adjust malefirstName to align with its female counterpart, and java naming conventions - maleFirstName#1519
kingthorin merged 2 commits intodatafaker-net:mainfrom
apollo-de:fix/datafaker-1518

Conversation

@apollo-de
Copy link
Copy Markdown
Contributor

@apollo-de apollo-de commented Mar 24, 2025

Fixes #1518

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Mar 24, 2025

PR Summary

  • Deprecation of malefirstName method
    The outdated malefirstName method is now marked as obsolete. As a replacement, it is suggested to transition to using the maleFirstName method.

  • Introduction of maleFirstName method
    A new method named maleFirstName has been implemented. Its function is to generate and return a random male first name, utilizing a process known as a resolver.

  • Update in Test Methods
    Accompanying this change, the references in the test scripts have also been transitioned from malefirstName to maleFirstName. This is to ensure that tests remain accurate and relevant to the new method.

Copy link
Copy Markdown
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kingthorin kingthorin changed the title Fix/datafaker 1518 Adjust malefirstName to align with its female counterpart, and java naming conventions - maleFirstName Mar 24, 2025
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (8f2b819) to head (c587fea).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1519      +/-   ##
============================================
- Coverage     92.49%   92.48%   -0.02%     
  Complexity     3274     3274              
============================================
  Files           325      325              
  Lines          6438     6439       +1     
  Branches        625      625              
============================================
  Hits           5955     5955              
  Misses          334      334              
- Partials        149      150       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asolntsev asolntsev added this to the 2.4.3 milestone Mar 24, 2025
@kingthorin kingthorin merged commit 994f99c into datafaker-net:main Mar 24, 2025
13 checks passed
@apollo-de apollo-de deleted the fix/datafaker-1518 branch March 25, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

malefirstName() method should be renamed to maleFirstName() analogous to femaleFirstName().

4 participants