Skip to content

Update Dota2Provider dota2.yml#1511

Merged
kingthorin merged 1 commit intodatafaker-net:mainfrom
therepanic:update-dota2-game-provider
Mar 3, 2025
Merged

Update Dota2Provider dota2.yml#1511
kingthorin merged 1 commit intodatafaker-net:mainfrom
therepanic:update-dota2-game-provider

Conversation

@therepanic
Copy link
Copy Markdown
Contributor

A new patch came out recently and I think it's worth updating some of the data

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Mar 3, 2025

PR Summary

  • New Feature Added to Dota2 Provider
    The Dota2 provider class now includes a new method called neutralEnchantment. This addition will help in obtaining the names of neutral enchantments from the data source.

  • Updates to Dota2 Database
    The dota2.yml file has been expanded to include more enchantment names and values, introducing terms like "Orb of Frost", "Brigand's Blade", and "Essence Ring". In addition, new enchantments including "alert", "audacious", and "vampiric" have been incorporated into the system.

  • Test Coverage for New Feature
    The Dota2Test class has been updated to feature a new test for the recently added neutralEnchantment method. This ensures that the functionality of this feature is correctly tested and solid, maintaining the software's reliability.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.45%. Comparing base (0a47bdc) to head (e1a4fde).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1511      +/-   ##
============================================
+ Coverage     92.41%   92.45%   +0.03%     
- Complexity     3270     3271       +1     
============================================
  Files           325      325              
  Lines          6437     6438       +1     
  Branches        625      625              
============================================
+ Hits           5949     5952       +3     
+ Misses          336      334       -2     
  Partials        152      152              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kingthorin kingthorin merged commit 5e52e39 into datafaker-net:main Mar 3, 2025
10 checks passed
@therepanic therepanic deleted the update-dota2-game-provider branch March 3, 2025 15:17
@asolntsev asolntsev added this to the 2.4.3 milestone Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants