Skip to content

Add Trino Community Broadcast 71: Fake it real good to Articles and News page#1507

Merged
asolntsev merged 1 commit intodatafaker-net:mainfrom
Lukashmoser:datafaker_tcb
Feb 28, 2025
Merged

Add Trino Community Broadcast 71: Fake it real good to Articles and News page#1507
asolntsev merged 1 commit intodatafaker-net:mainfrom
Lukashmoser:datafaker_tcb

Conversation

@Lukashmoser
Copy link
Copy Markdown
Contributor

@Lukashmoser Lukashmoser commented Feb 28, 2025

Refer to discussion in #1503

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Feb 28, 2025

PR Summary

  • New Entry Added For A Future Broadcast Episode
    This PR includes the addition of a new entry that is scheduled for February 27, 2025. This episode features a conversation with Manfred Moser, Cole Bowden, and Jan Waś, wherein they will discuss the newly developed Faker connector and Datafaker library.

  • Link to Trino Community Broadcast Provided
    Additionally, a web link is incorporated directing to the Trino Community Broadcast, where this episode will be made available. Visit the site to stay updated: Trino broadcast

@Lukashmoser Lukashmoser mentioned this pull request Feb 28, 2025
Closed
mosabua
mosabua reviewed Feb 28, 2025
View reviewed changes
docs/in-the-media/links.md Outdated

*Manfred Moser* and *Cole Bowden* are joined by *Jan Waś* in Trino Community BroadCast 71: Fake it real good to learn about the new Faker connector and the Datafaker library. You can find the episode here:

https://trino.io/broadcast/
Copy link
Copy Markdown

@mosabua mosabua Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust to link to the actual episode so over time it does not become an invalid link -p

Suggested change
https://trino.io/broadcast/
https://trino.io/broadcast/71.html

mosabua
mosabua reviewed Feb 28, 2025
View reviewed changes
docs/in-the-media/links.md Outdated

**February 27, 2025**

*Manfred Moser* and *Cole Bowden* are joined by *Jan Waś* in Trino Community BroadCast 71: Fake it real good to learn about the new Faker connector and the Datafaker library. You can find the episode here:
Copy link
Copy Markdown

@mosabua mosabua Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Manfred Moser* and *Cole Bowden* are joined by *Jan Waś* in Trino Community BroadCast 71: Fake it real good to learn about the new Faker connector and the Datafaker library. You can find the episode here:
*Manfred Moser* and *Cole Bowden* are joined by *Jan Waś* in "Trino Community BroadCast 71: Fake it real" good to learn about the new Faker connector and the Datafaker library. You can find the episode here:

mosabua
mosabua approved these changes Feb 28, 2025
View reviewed changes
Copy link
Copy Markdown

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from minor nits.

@Lukashmoser
Copy link
Copy Markdown
Contributor Author

Lukashmoser commented Feb 28, 2025

Thx @mosabua for the edits, pr has been updated

mosabua
mosabua approved these changes Feb 28, 2025
View reviewed changes
Copy link
Copy Markdown

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me now.

kingthorin
kingthorin approved these changes Feb 28, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (38cf87a) to head (9aad8ad).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1507      +/-   ##
============================================
+ Coverage     92.43%   92.48%   +0.04%     
- Complexity     3270     3273       +3     
============================================
  Files           325      325              
  Lines          6437     6437              
  Branches        625      625              
============================================
+ Hits           5950     5953       +3     
  Misses          335      335              
+ Partials        152      149       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asolntsev asolntsev added this to the 2.4.3 milestone Feb 28, 2025
@asolntsev asolntsev merged commit 565a477 into datafaker-net:main Feb 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kingthorin kingthorin kingthorin approved these changes

+1 more reviewer

@mosabua mosabua mosabua approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@Lukashmoser @codecov-commenter @mosabua @kingthorin @asolntsev