Added Uzbek locale support with uz.yml and _UZ.yml#1504
Added Uzbek locale support with uz.yml and _UZ.yml#1504snuyanzin merged 3 commits intodatafaker-net:mainfrom jahongir-torayev:uz-locale
Conversation
PR Summary
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1504 +/- ##
=========================================
Coverage 92.38% 92.38%
Complexity 3269 3269
=========================================
Files 325 325
Lines 6437 6437
Branches 625 625
=========================================
Hits 5947 5947
Misses 337 337
Partials 153 153 ☔ View full report in Codecov by Sentry. |
README.md
Outdated
| * tr (Turkish) | ||
| * th_TH (language: Thai, country: Thailand) | ||
| * uk_UA (language: Ukrainian, country: Ukraine) | ||
| * uz (language: Uzbek, country: Uzbekistan) |
There was a problem hiding this comment.
This line seems to be incorrect
if you look at others then letters before underscore mean language and after country name.
In your case there is only a part before underscore, then only language should be in parenthesis (similar to tr (Turkish) above)
There was a problem hiding this comment.
Ok, I'll fix that.
There was a problem hiding this comment.
I updated the readme file. I changed uz (language: Uzbek, country: Uzbekistan) to uz (Uzbek)
README.md
Outdated
| faker. | ||
|
|
||
| expression("#{letterify 'test????test'}"); // testqwastest | ||
| faker. | ||
|
|
||
| expression("#{numerify '#test#'}"); // 3test5 | ||
| faker. | ||
|
|
||
| expression("#{templatify 'test','t','q','@'}"); // @esq | ||
| faker. | ||
|
|
||
| expression("#{examplify 'test'}"); // ghjk | ||
| faker. | ||
|
|
||
| expression("#{regexify '[a-z]{4,10}'}"); // wbevoa | ||
| faker. | ||
|
|
||
| expression("#{options.option '23','2','5','$','%','*'}"); // * | ||
| faker. | ||
|
|
||
| expression("#{date.birthday 'yy DDD hh:mm:ss'}"); // 61 327 08:11:45 | ||
| faker. | ||
|
|
||
| expression("#{csv '1','name_column','#{Name.first_name}','last_name_column','#{Name.last_name}'}"); |
There was a problem hiding this comment.
Hmm...
I'm pretty sure all these and most of other changes have nothing to do with the actual PR description. Please stick only to those changes which are solving the issue mentioned in PR description. If some other things should be changed we can discuss it in separate PRs
I’ve added the uz.yml and _UZ.yml files with localized data for Uzbek (names, addresses, phone numbers, etc.) and updated README.md. Tests confirmed that the data loads correctly (e.g., names like "Ali", addresses like "Toshkent"). Let me know if you need any further adjustments!