Skip to content

Added Uzbek locale support with uz.yml and _UZ.yml#1504

Merged
snuyanzin merged 3 commits intodatafaker-net:mainfrom
jahongir-torayev:uz-locale
Feb 27, 2025
Merged

Added Uzbek locale support with uz.yml and _UZ.yml#1504
snuyanzin merged 3 commits intodatafaker-net:mainfrom
jahongir-torayev:uz-locale

Conversation

@jahongir-torayev
Copy link
Copy Markdown
Contributor

I’ve added the uz.yml and _UZ.yml files with localized data for Uzbek (names, addresses, phone numbers, etc.) and updated README.md. Tests confirmed that the data loads correctly (e.g., names like "Ali", addresses like "Toshkent"). Let me know if you need any further adjustments!

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Feb 26, 2025

PR Summary

  • Addition of Uzbek Language Support
    This change includes support for the Uzbek language in the README.md and Locality.java files. This will make the application more accessible and user-friendly for Uzbek-speaking users.

  • Update in Locality class
    The Locality class has been updated to incorporate "_uz" as part of the locales. This allows the software to recognize and correctly process information related to the Uzbek language.

  • New Resource File for Uzbekistan
    A new resource file has been introduced, _UZ.yml, which contains localized data specific to Uzbekistan. This includes details about address, passport, and phone number formats, providing improved accuracy when dealing with data related to Uzbekistan.

@asolntsev asolntsev added this to the 2.4.3 milestone Feb 26, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 26, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.38%. Comparing base (f18f49c) to head (51fbafb).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1504   +/-   ##
=========================================
  Coverage     92.38%   92.38%           
  Complexity     3269     3269           
=========================================
  Files           325      325           
  Lines          6437     6437           
  Branches        625      625           
=========================================
  Hits           5947     5947           
  Misses          337      337           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated
* tr (Turkish)
* th_TH (language: Thai, country: Thailand)
* uk_UA (language: Ukrainian, country: Ukraine)
* uz (language: Uzbek, country: Uzbekistan)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems to be incorrect
if you look at others then letters before underscore mean language and after country name.
In your case there is only a part before underscore, then only language should be in parenthesis (similar to tr (Turkish) above)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll fix that.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the readme file. I changed uz (language: Uzbek, country: Uzbekistan) to uz (Uzbek)

README.md Outdated
Comment on lines +101 to +124
faker.

expression("#{letterify 'test????test'}"); // testqwastest
faker.

expression("#{numerify '#test#'}"); // 3test5
faker.

expression("#{templatify 'test','t','q','@'}"); // @esq
faker.

expression("#{examplify 'test'}"); // ghjk
faker.

expression("#{regexify '[a-z]{4,10}'}"); // wbevoa
faker.

expression("#{options.option '23','2','5','$','%','*'}"); // *
faker.

expression("#{date.birthday 'yy DDD hh:mm:ss'}"); // 61 327 08:11:45
faker.

expression("#{csv '1','name_column','#{Name.first_name}','last_name_column','#{Name.last_name}'}");
Copy link
Copy Markdown
Collaborator

@snuyanzin snuyanzin Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...
I'm pretty sure all these and most of other changes have nothing to do with the actual PR description. Please stick only to those changes which are solving the issue mentioned in PR description. If some other things should be changed we can discuss it in separate PRs

@snuyanzin snuyanzin merged commit d652149 into datafaker-net:main Feb 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants